-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Chat - cursor isn't moved to the end of the pasted text while context menu is open #43717
Comments
Triggered auto assignment to @carlosmiceli ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
I think this is the PR that we need to fix/revert: https://github.com/Expensify/App/pull/39520/files cc @jnowakow @adamgrzybowski @fedirjh @roryabraham anyone knows what the issue may be and can fix it? There's a lot of code in that PR so ideally someone with more context can take this. |
Ok, will jump in. |
Haven't been able to figure this one out yet (very unfamiliar with these components and logic) and I have to leave. @jnowakow @adamgrzybowski @fedirjh @roryabraham please jump in if you see this and it's still blocking, thank you! 🙏 |
@lanitochka17 it seems that this PR partially solves the problem. There's a problem that the cursor doesn't move to the end of the copied text but it may be problem with Composer. opened-menu.movcopy-and-paste.movI don't know if this is a big problem. I checked all messengers that I had access to and none of them is allowing to paste text while context menu is open. Here is example from slack: slack-example.mov |
@jnowakow Thank you! The thing is that in production it is possible to paste while context menu is open, so there should be something else that must be changed... Did you test it in main prior to your PR? |
Job added to Upwork: https://www.upwork.com/jobs/~010f78034d91b41a47 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 ( |
@mountiny @ishpaul777 @jnowakow Removing deploy blocker because it's such an edge case, but will keep it as a daily bug until it's solved. Sounds good? |
@ishpaul777 when you open context menu and doesn't click anything in it you can paste: pasting.movBut the cursor isn't moved to the end of the line so it doesn't look good. |
Thanks for confirming @jnowakow. @carlosmiceli Can you please help change the the issue title, expected result and actual result in issue OP. Title: Expected Result: Actual Result: |
I believe the cursor positioning could be related to the same root cause as this one: #42216 |
@carlosmiceli, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Waiting for proposals |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue is no longer producable. Screen.Recording.2024-06-25.at.11.46.12.PM.mov |
@ishpaul777 Gotcha, is it ok to go ahead and close it then or is there something else that should be done in terms of contributor compensation? |
Its ok to close, no contributor was hired and there was not much work as c+ for me. 😄 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Cursor is moved to the end of the pasted text.
Actual Result:
Cursor isn't moved to the end of the pasted text.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6512205_1718297719132.20240614_005446.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ishpaul777The text was updated successfully, but these errors were encountered: