[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Workspace - Workspace chat reappears in LHN after leaving the chat and relogin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is invited to a workspace.

1. Go to staging.new.expensify.com
2. Go to workspace chat as workspace member.
3. Click on the chat header.
4. Click Leave.
5. Log out.
6. Log in.

Expected Result:

The workspace chat will not appear in LHN because user left the workspace chat.

Actual Result:

The workspace chat reappears in LHN after leaving the chat and relogin.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

20240617_201359.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@nkuoch FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[johnmlee101]

I don't see a cause from Web-E https://github.com/Expensify/Web-Expensify/compare/b7840b36...52842eef so I'm going to remove the DeployBlocker label

[AndrewGable]

Pretty sure this is the PR #43065 that started allowing users to leave workspace chats, so we can try to revert that PR and try again

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix deploy blocker where people can leave their own workspace chats #43870

If no regressions arise, payment will be issued on 2024-06-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch / @jasperhuangg] The PR that introduced the bug has been identified. Link to the PR: Came from Prevent removal of admin and default members from workspace chats #43065, but it wasn't because of bad coding practices, we just weren't clear on the expected behavior requested in the issue.
• [@nkuoch / @jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@nkuoch / @jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@nkuoch / @jasperhuangg] Determine if we should create a regression test for this bug.
• [@nkuoch / @jasperhuangg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[brunovjk]

thank you for the prompt fix @jasperhuangg

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix deploy blocker where people can leave their own workspace chats #43870

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch / @jasperhuangg] The PR that introduced the bug has been identified. Link to the PR:
• [@nkuoch / @jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@nkuoch / @jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@nkuoch / @jasperhuangg] Determine if we should create a regression test for this bug.
• [@nkuoch / @jasperhuangg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: