Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [Rules] Connect Rules to upgrade flows #43915

Closed
garrettmknight opened this issue Jun 18, 2024 · 30 comments
Closed

[$250] [Rules] Connect Rules to upgrade flows #43915

garrettmknight opened this issue Jun 18, 2024 · 30 comments
Assignees
@garrettmknight @allroundexperts @aimane-chnaif
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@garrettmknight
Copy link
Contributor

garrettmknight commented Jun 18, 2024 •
edited
Loading

Rules have been released to beta in NewDot, we'll need to connect our upgrade flow in the Rules section of the workspace editor.

UI in the Upgrades doc here.

Translations for the upgrade copy are here.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012600ef2e91fde48d
  • Upwork Job ID: 1821258868868350174
  • Last Price Increase: 2024-08-07
Issue OwnerCurrent Issue Owner: @allroundexperts
@garrettmknight garrettmknight added the Weekly KSv2 label Jun 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2024
@garrettmknight
Copy link
Contributor Author

Still on hold pending BE issues

@melvin-bot melvin-bot bot removed the Overdue label Jun 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@garrettmknight
Copy link
Contributor Author

Still on hold pending BE issues

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@garrettmknight
Copy link
Contributor Author

Still on hold pending implementation - this one actually might take a while so I could see us closing and just letting them update when it's done. Gonna leave it open until we have a confirmation on an internal convo though.

@garrettmknight
Copy link
Contributor Author

Same as above, when we're ready to close out Upgrades, I'll just move this over.

@garrettmknight garrettmknight changed the title [HOLD] [Upgrades] Connect Rules to upgrade flows [Advanced Approval Workflows] Connect Rules to upgrade flows Jul 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
@garrettmknight
Copy link
Contributor Author

Same as above

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2024
@JmillsExpensify
Copy link

FYI, this can start being worked on. The relevant PRs will be on staging in the next deploy.

@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label Aug 7, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012600ef2e91fde48d

@melvin-bot melvin-bot bot changed the title [Advanced Approval Workflows] Connect Rules to upgrade flows [$250] [Advanced Approval Workflows] Connect Rules to upgrade flows Aug 7, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 7, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 7, 2024

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 7, 2024
@garrettmknight garrettmknight added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 7, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 7, 2024
@allroundexperts
Copy link
Contributor

I'm just waiting on #46617 to get merged before adding this in.

@allroundexperts
Copy link
Contributor

Did the PR that adds rule got reverted? I am no longer seeing it in the workspace more features section. I see the following:

Screenshot 2024-08-15 at 5 12 43 AM

@allroundexperts
Copy link
Contributor

I see that #47468 is still in draft state.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 20, 2024

@garrettmknight, @allroundexperts, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 20, 2024
@garrettmknight
Copy link
Contributor Author

Bumped that other issue/PR to see when they expect to complete.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 22, 2024

@garrettmknight, @allroundexperts, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 26, 2024

@garrettmknight, @allroundexperts, @aimane-chnaif 10 days overdue. I'm getting more depressed than Marvin.

@garrettmknight
Copy link
Contributor Author

More changes requested - Going to put this one on Hold until #47468 is complete.

@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@garrettmknight garrettmknight changed the title [$250] [Rules] Connect Rules to upgrade flows [HOLD on PR #47468] [$250] [Rules] Connect Rules to upgrade flows Aug 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
@garrettmknight
Copy link
Contributor Author

Still waiting on #47468

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 30, 2024
@garrettmknight
Copy link
Contributor Author

Still waiting on #47468

@melvin-bot melvin-bot bot removed the Overdue label Sep 2, 2024
@garrettmknight
Copy link
Contributor Author

Still waiting on #47468

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 9, 2024

@garrettmknight, @allroundexperts, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@aimane-chnaif
Copy link
Contributor

#47468 reached staging

@melvin-bot melvin-bot bot removed the Overdue label Sep 10, 2024
@garrettmknight garrettmknight changed the title [HOLD on PR #47468] [$250] [Rules] Connect Rules to upgrade flows [$250] [Rules] Connect Rules to upgrade flows Sep 11, 2024
@garrettmknight
Copy link
Contributor Author

@allroundexperts good to go now that we're on staging?

@allroundexperts
Copy link
Contributor

Checking now.

@allroundexperts
Copy link
Contributor

This seems to have been added already here.

@garrettmknight
Copy link
Contributor Author

Huh, looks like they went ahead and did it - @allroundexperts did you have a PR up?

@allroundexperts
Copy link
Contributor

Nops, I did not.

@garrettmknight
Copy link
Contributor Author

Cool, we'll just close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettmknight garrettmknight

@allroundexperts allroundexperts

@aimane-chnaif aimane-chnaif

Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
[#whatsnext] #expense
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JmillsExpensify @garrettmknight @allroundexperts @aimane-chnaif