[HOLD for payment 2024-11-13] [$250] Web - Messages - Unread marker is not displayed after the messages are received

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4632530
Email or phone of affected tester (no customers): test.iris.santos+17062024@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions:

• Navigate to https://staging.new.expensify.com/
  in any browser
• Log in with an account
• Log in with a secondary account in another device or incognito tab.

1. Open a 1:1 conversation with a user you have access with.
2. While viewing the 2 conversations at the same time
3. Turn off the internet connection in the device
4. As the secondary user - send a message to the account you're logged in the testing device
5. Turn on the internet connection
6. See the message sent from the other account

Expected Result:

The unread marker (green line and 'New' label) is displayed in the conversation after the messages are received

Actual Result:

The unread marker (green line and 'New' label) is NOT displayed in the conversation after the messages are received

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6516395_1718656031630.CleanShot_2024-06-17_16.13.19-e.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbab0fd3569bf04f
• Upwork Job ID: 1823480826689774019
• Last Price Increase: 2024-09-03
• Automatic offers:
• brunovjk | Reviewer | 103816429

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

I'll review this one soon.

[alexpensify]

Still on my testing radar

[alexpensify]

Other GHs and customer tasks have been a higher priority, I'll get to this one soon.

[alexpensify]

After reviewing these steps, I don't think it's a dupe but there is a known issue with the new message banner when online. It's being addressed here: #43486. I'm going to put this GH on hold and then test it again after #43486 in Production. Setting a reminder to check next week.

---

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.

If this GitHub needs an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

[alexpensify]

Still on hold for #43486

[alexpensify]

No update, on hold for #43486

[alexpensify]

@bernhardoj and @shubham1206agra - I believe this one is resolved by the other GH - #43486, but let me know if you disagree. Thanks!

[bernhardoj]

The PR for #43486 is actually reverted and the new PR hasn't been merged yet.

[alexpensify]

Thanks, I missed that there was a revert. Ok, keeping this one on hold.

[alexpensify]

Weekly Update: On hold for #43486

[alexpensify]

@bernhardoj and @shubham1206agra can I get your feedback if we should close this one or move forward with the next steps? Thanks!

[shubham1206agra]

@alexpensify Can you please retest this?

[trjExpensify]

Chat bug, removing from wave-collect.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Display unread marker for messages that were received while offline #49480

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @brunovjk requires payment automatic offer (Reviewer)

[melvin-bot]

@brunovjk @alexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[chrispader]

Since this has been merged to production, i think the deploy blocker is obsolete? @brunovjk

[brunovjk]

I think so, but I'm not sure what happened here :/ I'll ask on Slack later.

[brunovjk]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: Applause - Internal Team

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

• User logged into the platform with two separate accounts on different devices or browser windows.

Test:

1. On device A, turn off the internet connection.
2. On device B, send a message to the account on device A.
3. On device A, turn on the internet connection.
4. Verify if the unread marker (green line and 'New' label) is displayed after receiving the message.

Do we agree 👍 or 👎

[alexpensify]

Payouts due: 2024-11-13

• Contributor: @chrispader payment handled via vendor
• Reviewer: $250 @brunovjk

Upwork job is here.

[alexpensify]

All set, I've completed the payment to @brunovjk via Upwork. I'll work on the QA test prep later this week.

[alexpensify]

Not overdue

[brunovjk]

Update: Not overdue, working on the QA test. @alexpensify, do you think I can help in any way?

[alexpensify]

No, sorry, other GHs have been a priority. I'll get to the regression test soon.

[melvin-bot]

@tylerkaraszewski, @alexpensify, @chrispader, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

With the slower week, I'll be working on the last step soon.

[alexpensify]

Closing - all set here