[HOLD for payment 2024-07-30] [$250] Distance - Route in distance editor doesn't load after fresh sign in

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9-0-0-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4620930
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a distance expense.
4. Go to transaction thread.
5. Click Distance.
6. Note that the green route is shown.
7. Sign out and back in
8. Go to the transaction thread in Step 3.
9. Click Distance.

Expected Result:

The route will load

Actual Result:

The route does not load

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-01.at.10.03.26.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a809b3d1bd11c266
• Upwork Job ID: 1807822900424921117
• Last Price Increase: 2024-07-01

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

@neil-marcellini I'm curious about your thoughts here. Would you expect the green route to persist after the user clears their cache?

[johncschuster]

@neil-marcellini Assigning to you just to make sure my question is on your radar. Please feel free to drop off after!

[neil-marcellini]

We shouldn't really report bugs which include a debug only feature like clearing the cache. I was tempted to close the issue, but first I checked if a similar problem was reproducible after signing out. It looks like that does in fact present a real issue, so I'm going to update the description. I'm happy to stay on to manage this externally.

Screen.Recording.2024-07-01.at.10.03.26.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a809b3d1bd11c266

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[izarutskaya]

The team discovered the route also does not generate after changing waypoints in offline mode.

Recording.189.mp4

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The distance green line route disappears after re-login.

What is the root cause of that problem?

The green line route is coming from the transaction route coordinate data.

App/src/components/DistanceRequest/DistanceRequestFooter.tsx

Line 112 in a84f68e

directionCoordinates={(transaction?.routes?.route0?.geometry?.coordinates as Array<[number, number]>) ?? []}

The coordinate data is retrieved from GetRoute/Draft API. However, the data (routes) isn't saved on the BE and lost when we re-login as pointed out in here.

The GetRoute/Draft API is only called when the waypoints are changed.

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 93 in a84f68e

const shouldFetchRoute = (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;

But because we don't change it, the coordinate data stays empty and the route green line is gone.

What changes do you think we should make in order to solve the problem?

Trigger the GetRoute/Draft API if the routes data is missing.

const shouldFetchRoute = (!transaction?.routes || isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;

[melvin-bot]

@johncschuster, @neil-marcellini, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@johncschuster @neil-marcellini @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix route in distance editor doesn't load after fresh sign in #45139

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bernhardoj]

@thesahindia @neil-marcellini I found an issue with our PR, so I create a follow up here

[johncschuster]

Thanks for the new PR! I'll issue payment once that PR passes the regression threshold.

[johncschuster]

Looks like we're waiting on a deploy to prod

[johncschuster]

Deployed to prod today! Payment should be issued on July 30 👍

[johncschuster]

Downgrading the label while we wait for the payment date. We're still on track to pay this out on the 30th

[johncschuster]

Payment Summary:

Contributor: @bernhardoj owed $250 via NewDot
Contributor+: @thesahindia owed $250 via NewDot

[johncschuster]

@thesahindia can you complete the BZ Checklist above? Thank you!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @bernhardoj owed $250 via NewDot
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@johncschuster)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1807822900424921117/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[johncschuster]

@thesahindia bump on the BZ Checklist

[thesahindia]

Sorry for the delay. This was an improvement so we can skip the checklist.

We can add a test case, here are the steps -

1. Open a workspace chat
2. Submit a distance request
3. Log out and log in back
4. Open the submitted distance request transaction thread
5. Press the "Distance" field
6. Verify the map shows the green line route

[johncschuster]

Sweet. Thank you for clarifying that! We're all done here!

[JmillsExpensify]

$250 approved for @thesahindia