Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] [External] Create new Card List page #44310

Closed
mountiny opened this issue Jun 24, 2024 · 32 comments
Closed

[Workspace Feeds] [External] Create new Card List page #44310

mountiny opened this issue Jun 24, 2024 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@mountiny
Copy link
Contributor Author

Wrong Dylan

@allgandalf
Copy link
Contributor

allgandalf commented Jun 25, 2024

I can review this when ready 👍

@VickyStash
Copy link
Contributor

Updates for today:

  • Added a new route and component for WorkspaceCardPageFree page
  • Implemented Card List display using CardListHeader and CardListRow components

@VickyStash
Copy link
Contributor

Updates for today:

  • Implemented Current Balance, Remaining Limit, and Cash Back display with modals.
  • Added function for OpenPolicyExpensifyCardsPage API call and ONYX keys/type to easily get the data in the future.

Plans for tomorrow:

  • Add Request limit increase button functionality
  • Check the UI on the different platforms
  • Prepare the PR for review

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jun 27, 2024
@VickyStash
Copy link
Contributor

The PR is ready for the review.

@VickyStash
Copy link
Contributor

Note: I'm going to be OOO Jul 1- Jul 7 🌴

@DylanDylann DylanDylann removed their assignment Jul 5, 2024
@allgandalf
Copy link
Contributor

This was deployed to production, lets close this one out @mountiny

@koko57
Copy link
Contributor

koko57 commented Jul 8, 2024

@allgandalf I think we should have it opened - we will need to integrate it with the BE when it's ready

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
Copy link

melvin-bot bot commented Jul 22, 2024

Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

  • Contributor: @VickyStash is from an agency-contributor and not due payment
  • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@johncschuster)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@johncschuster
Copy link
Contributor

johncschuster commented Jul 22, 2024

Payment Summary:

Contributor+: @allgandalf paid $250 via Upwork

I spoke with @allgandalf and have understood they will be paid as part of a larger project. They do not require payment for this issue.

@allgandalf
Copy link
Contributor

Thanks for the summary @johncschuster , this is a project work and payments are for the end of the project, we can put this to weekly and no payments :) thanks

@johncschuster johncschuster added Weekly KSv2 and removed Daily KSv2 labels Jul 22, 2024
@johncschuster johncschuster changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Create new Card List page [Workspace Feeds] [External] Create new Card List page Jul 22, 2024
@Travis452
Copy link

Hello, could I contribute to this project?

Copy link

melvin-bot bot commented Jul 23, 2024

📣 @Travis452! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot melvin-bot bot added the Overdue label Jul 30, 2024
@johncschuster
Copy link
Contributor

How's this one going?

@melvin-bot melvin-bot bot removed the Overdue label Jul 30, 2024
@allgandalf
Copy link
Contributor

I assume the BE is still not ready for this to test, so lets keep this open

1 similar comment
@allgandalf

This comment was marked as duplicate.

@VickyStash
Copy link
Contributor

Since OpenPolicyExpensifyCardsPage API endpoint was implemented I'm going to finalize BE integration tomorrow.
I'll keep you updated about it.

@VickyStash
Copy link
Contributor

VickyStash commented Aug 7, 2024

Update: waiting for this PR to be merged to continue
I was able to emit a new card using the PR's branch, so I can progress

@VickyStash
Copy link
Contributor

Updates:

  • Enabled OpenPolicyExpensifyCardsPage API call, tested the received data on different screens
  • Use workspaceAccountID instead of policyID inside Onyx keys to receive the correct data
  • Updated the code to use unapprovedExpenseLimit as a card limit
  • Working on the correct card list page loading

The PR will be opened to the review only when next PR's are merged: #46570, #46564

@mountiny
Copy link
Contributor Author

mountiny commented Aug 8, 2024

Thanks!

@VickyStash
Copy link
Contributor

Updates:

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 13, 2024
@VickyStash
Copy link
Contributor

The PR with OpenPolicyExpensifyCardsPage API call integration is open for the review!

@mountiny
Copy link
Contributor Author

I believe this is all merged and we can close it

@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

9 participants