Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Wrong color is used for the active LHN item #44355

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 24, 2024 · 22 comments
Closed
1 of 6 tasks

[$250] Wrong color is used for the active LHN item #44355

m-natarajan opened this issue Jun 24, 2024 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719240834164559

Action Performed:

  1. Open app
  2. Check the background color of the LHN active item
  3. Click search
  4. Observe the background color of the active item

Expected Result:

Should be matching product color

Actual Result:

LHN is too dark color

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

CleanShot 2024-06-24 at 16 54 13@2x
CleanShot 2024-06-24 at 16 53 11@2x

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f381017700feec87
  • Upwork Job ID: 1810386505822534382
  • Last Price Increase: 2024-07-22
Issue OwnerCurrent Issue Owner: @fedirjh
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@devguest07
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong color is used for the active LHN item

What is the root cause of that problem?

Wrong background color used theme.buttonHoveredBG

https://github.com/Expensify/App/blob/main/src/styles/index.ts#L1802

What changes do you think we should make in order to solve the problem?

Wer should use the same color used for the search active menu item theme.border

return isMenuItem ? {backgroundColor: theme.border} : {backgroundColor: theme.buttonHoveredBG};

What alternative solutions did you explore?

@tienifr
Copy link
Contributor

tienifr commented Jun 25, 2024

Maybe this PR will fix it.

@shawnborton
Copy link
Contributor

Ah I do think that linked PR will fix things, so perhaps we can close this out.

@melvin-bot melvin-bot bot added the Overdue label Jun 27, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jul 2, 2024

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jul 4, 2024

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jul 8, 2024

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jul 8, 2024

@anmurali 12 days overdue now... This issue's end is nigh!

@anmurali
Copy link

anmurali commented Jul 8, 2024

To clarify as it confused me originally. This is the background color of the LHN items in the Home tab vs. Search tab

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@anmurali anmurali added the External Added to denote the issue can be worked on by a contributor label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f381017700feec87

@melvin-bot melvin-bot bot changed the title Wrong color is used for the active LHN item [$250] Wrong color is used for the active LHN item Jul 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@fedirjh
Copy link
Contributor

fedirjh commented Jul 9, 2024

@anmurali It seems like this was already fixed. I think this can be closed:

Screenshot 2024-07-09 at 12 19 25 PM Screenshot 2024-07-09 at 12 19 49 PM

Copy link

melvin-bot bot commented Jul 12, 2024

@anmurali, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jul 15, 2024

@anmurali let's close this one, it has been fixed.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jul 18, 2024

@anmurali, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@fedirjh
Copy link
Contributor

fedirjh commented Jul 22, 2024

Same update

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
Copy link

melvin-bot bot commented Jul 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jul 22, 2024

@anmurali @fedirjh this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Jul 25, 2024

@anmurali, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants