-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Wrong color is used for the active LHN item #44355
Comments
Triggered auto assignment to @anmurali ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Wrong color is used for the active LHN item What is the root cause of that problem?Wrong background color used https://github.com/Expensify/App/blob/main/src/styles/index.ts#L1802 What changes do you think we should make in order to solve the problem?Wer should use the same color used for the search active menu item Line 1315 in 3fab86f
What alternative solutions did you explore? |
Maybe this PR will fix it. |
Ah I do think that linked PR will fix things, so perhaps we can close this out. |
@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@anmurali 12 days overdue now... This issue's end is nigh! |
To clarify as it confused me originally. This is the background color of the LHN items in the Home tab vs. Search tab |
Job added to Upwork: https://www.upwork.com/jobs/~01f381017700feec87 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
@anmurali It seems like this was already fixed. I think this can be closed: |
@anmurali let's close this one, it has been fixed. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue not reproducible during KI retests. (First week) |
Same update |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.1-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719240834164559
Action Performed:
Expected Result:
Should be matching product color
Actual Result:
LHN is too dark color
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: