[$250] [HOLD payment 2024-08-09] [CRITICAL] [Guided setup] The onboarding flow can be dismissed by navigating to different route

[mountiny]

Problem

When new users sign up, they are presented with an onboarding flow. This flow is crucial in the user's onboarding journey and aims to set them up for success using the app. It also provides useful information for us. We need to ensure that every new user completes the onboarding flow.

However, the user is able to navigate to a different route in the app, either by going back into the browser or changing the URL directly to any other in-app URL and the modal is not shown again.

Solution

Find a generic navigation solution that will check the user's onboarding NVP value and whether the hasCompletedGuidedSetupFlow property is set to false, in which case we should present them with the modal.

Note that if its existing user is coming from oldDot, the onboarding NVP will be an empty array. So we only want to show the modal when the onboarding.hasCompletedGuidedSetupFlow === false

That is, however, true for any URL or deep link; if they go back in the browser, they should be re-navigated to the onboarding flow until it is completed. It's technically a blocking pattern for them.

cc @adamgrzybowski @WojtekBoman @kosmydel

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174de33b05a0967f8
• Upwork Job ID: 1821685945045066052
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[melvin-bot]

Current assignee @anmurali is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

Not looking for proposals really, would like to get the navigation team to find the best, performant and intuitive solution for this

[Kicu]

FYI update: This is being worked on by @adamgrzybowski and @filip-solecki and I have also chimed in a bit.
However for the past 2 days we had an unusual amount of navigation related bugs and regressions so its taking more time.

[allgandalf]

ahh, we merged a PR simplifying the Navigation, after the current deploy in progress , most of the issues should be resolved

[Kicu]

@allgandalf can you please share a link to which PR, so we can understand what's been done there?

[allgandalf]

if you are facing problem with tab navigation then there's the issue #36476 / PR #39520

[Kicu]

@allgandalf Im not sure we're talking about the same issue. No we're not facing a problem with tab navigation. This is an issue related to onboarding and that it can be dismissed before finishing it.

Neither of the tow PRs seem to be related to this issue? Also focus trap is quite old at this point

[allgandalf]

However for the past 2 days we had an unusual amount of navigation related bugs and regressions so its taking more time.

Can you be a little brief? what is happening exactly

[Kicu]

Sorry I don't really understand what want from me. Let's keep the discussion on this issue relevant to this issue I just gave a brief update that we're working on it.

[adamgrzybowski]

@mountiny we should have a draft today

[adamgrzybowski]

It's a bit tricky, but our solution seems to work so far

[adamgrzybowski]

@mountiny we have a draft PR here. We have some issue with redirecting when the user types RHP route in the URL bar but besides that it works quite well. We will work on that tomorrow. BTW We "hacked" the browser back button so the user have to complete the flow but maybe it is worth to display some kind a message to explain why the back button is blocked? What do you think?

[mountiny]

@adamgrzybowski great! thank you!

Yeah there should be an error on the modal shown. When you click outside of the modal now, we show it:

Can we show that too in this case?

[filip-solecki]

@mountiny I don't know if this is proper message cause user can select something and then click back button. We cannot easily check if user select something. What do you think about some generic message like: Finish onboarding so you can use the app or similar?

[adamgrzybowski]

@mountiny I haven't found a fix for the broken routes today. I will continue on Monday.

[melvin-bot]

@anmurali, @mountiny, @adamgrzybowski, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

This is been continuously worked on, Melvin!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0174de33b05a0967f8

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[mountiny]

This is ready for payment $250 to @allgandalf

[allgandalf]

Can you pay this one @anmurali , thanks :)

[allgandalf]

No checklist here, this was a cleanup from Guided setup

[melvin-bot]

@anmurali, @mountiny, @adamgrzybowski, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

@anmurali ready to be paid

[melvin-bot]

@anmurali, @mountiny, @adamgrzybowski, @allgandalf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@anmurali, @mountiny, @adamgrzybowski, @allgandalf 10 days overdue. I'm getting more depressed than Marvin.

[anmurali]

@allgandalf - https://www.upwork.com/nx/wm/offer/103712472

[anmurali]

Paid.