-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-10] [$250] [Search v1] "Description" is clickable but does not sort the expenses #44431
Comments
Triggered auto assignment to @Julesssss ( |
Triggered auto assignment to @JmillsExpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #vip-vsb |
Based on this issue which has only just been merged, this sounds like an edge case when we don't have any merchant details. I am removing the blocker labels and have raised the bug in both the issue and the PR in order to help with the follow-up fix: |
Job added to Upwork: https://www.upwork.com/jobs/~01d3c62ae3fec778ff |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Search - "Description" is clickable but does not sort the expenses What is the root cause of that problem?We don't have sorting property defined for description: Line 29 in 0c20881
What changes do you think we should make in order to solve the problem?Add Then, in
Update sorting property to this:
What alternative solution did you explore?We can prevent description from being clickable, like tax is not clickable. |
We already have description available. We should just extend the sorting functionality to allow for nested objects. |
PR here |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Payment Summary
BugZero Checklist (@JmillsExpensify)
|
Payment summary above is accurate. $250 to @s77rt for PR review. I assume that you'll be submitting this via New Expensify? |
@JmillsExpensify Yes. Just did! |
Going to close this then! I need a payment summary from Matt Allen, and asked him via DM. |
Contributor+: @s77rt due $250 via NewDot |
$250 approved for @s77rt |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44181
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
Expected Result:
The expenses can be sorted by description, since description is clickable.
Actual Result:
The expenses cannot be sorted by description, even though description is clickable.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6524639_1719356162097.20240626_065219.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: