-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] Send invoice - Hold option appears for invoice and error shows up when attempting to hold it #44450
Comments
Triggered auto assignment to @carlosmiceli ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hold option appears for invoice and error shows up when attempting to hold it What is the root cause of that problem?We are not checking if the report is an invoice report before adding the App/src/components/MoneyReportHeader.tsx Lines 258 to 263 in 0c20881
What changes do you think we should make in order to solve the problem?Check if the report is invoice here by adding the following code const isInvoiceReport = ReportUtils.isInvoiceReport(moneyRequestReport); Add if (!isOnHold && (isRequestIOU || canModifyStatus) && !isScanning && !isInvoiceReport) App/src/components/MoneyReportHeader.tsx Line 258 in 0c20881
What alternative solutions did you explore? (Optional) |
@etCoderDysto that looks promising, let's do it! |
Great! I am raising ASAP. |
Current assignee @carlosmiceli is eligible for the DeployBlockerCash assigner, not assigning anyone new. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@etCoderDysto Any update here? |
Pr is almost ready. It will be ready for review under 30 minutes. |
@etCoderDysto Can you confirm whether or not this came from the following PR? #43618 |
I have checked with git blame and the issue seems to come from the PR. |
@yuwenmemon @carlosmiceli |
@etCoderDysto Reviewing. |
@yuwenmemon Just approved/merged the PR. |
Triggered auto assignment to @abekkala ( |
The PR has been CPed and QA has confirmed it worked so removing the DB label |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
PAYMENT SUMMARY FOR JUL 10
@etCoderDysto I'm having a hard time finding your profile in Upwork. Can you link it here and I can send your offer! |
updated summary above with your offer |
I have accepted the offer. Thank you! |
Since we are removing three-dot menu in recent releases, I don't think we need to create a regression test step. |
@etCoderDysto payment sent and contract ended - thank you! 🎉 |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Hold option should not appear for invoice if it is not supported (production behavior)
Actual Result:
Hold option appears for invoice and error shows up when attempting to hold the invoice
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6525058_1719394493471.20240626_173231.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @abekkalaThe text was updated successfully, but these errors were encountered: