Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread messages are shown in the LHN whenever a report data is exported to a CSV #44698

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 1, 2024 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1719592386443209

Action Performed:

  1. Export a report data to a CSV
  2. verify the LHN

Expected Result:

These reports should not appear unread in the LHN

Actual Result:

  • Exporting to CSV is a report action that we call a “system message”
  • Recently implemented a change internally such as all “system messages” are marked as read
  • Despite that, every time the team exports report data to a CSV, LHN is showing unread reports as result of the CSV export
  • We’ve confirmed that the lastReadTime was correctly set to a time later than system message for the CSV

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

CleanShot 2024-06-28 at 10 38 22@2x

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jul 1, 2024

Triggered auto assignment to @nkuoch (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 1, 2024
@m-natarajan
Copy link
Author

#44683

@hurali97
Copy link
Contributor

hurali97 commented Jul 2, 2024

@muttmuure Please assign this to me 👋

@muttmuure
Copy link
Contributor

Ty!

@muttmuure muttmuure assigned deetergp and unassigned nkuoch Jul 2, 2024
@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Jul 3, 2024
@deetergp
Copy link
Contributor

deetergp commented Jul 3, 2024

@hurali97 I suspect this is related to/a duplicate of this GH #44693 so I'd hold at least until that hits production and we do some testing.

@deetergp deetergp removed the Daily KSv2 label Jul 3, 2024
@deetergp
Copy link
Contributor

Investigations are still ongoing with the issue this dupes. Will update here when we know more.

Copy link

melvin-bot bot commented Jul 15, 2024

@deetergp @JmillsExpensify @hurali97 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@puneetlath
Copy link
Contributor

Is this issue different than #44693?

@deetergp
Copy link
Contributor

No, I don't think so. This is a dupe of that issue. Closing…

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

7 participants