[HOLD for payment 2024-08-07] [Search v2.1] [App] Create advanced filters

[luacmartins]

Implement this section of the design doc.

Holding on:

• [HOLD for payment 2024-07-24] [Search v2] [App] Create getFilters #45025

cc @adamgrzybowski @Kicu @WojtekBoman

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

Maybe for this one we can break it down into multiple PRs, maybe adding a couple of filters at a time

[Kicu]

yeah sounds good 👍

Let me take care of this task, and I will start with small initial PR, after that if I see possibility of some parallel work, then we will divide this between me and Wojtek if that would make sense. Will be doing smaller PRs with batches of filters like you suggested.

However I have a question: where do I get the values of some filters from? In, Currency, Merchant - are they somewhere inside Onyx easy to be used?

What about:

• Tax
• report ID
• Category
• Tag

And in general: should these filters values mostly be generated inside App using existing data, or come from backend?

[luacmartins]

These values should come from Onyx for now. So:

• in - all report_ keys in Onyx. We should show a selection list of reports like we do in ChatFinderPage
• currency - reuse CurrencySelectionList component, data source
• merchant - text input, user can enter whatever they want
• tax - policy_<id>.tax. Maybe we can reuse TaxPicker
• category - policyCategories_. Maybe we can reuse CategoryPicker
• tag - policyTags_. Maybe we can reuse TagPicker
• reportID - text input, takes in a list of reportIDs separated by comma

For tax, category and tag we need to combine the data from all policies available in Onyx. I think to reuse the components as is, we might have to lift that Onyx connection and pass the data.

[luacmartins]

Ready to be worked on!

[Kicu]

Will start today, possibly bring 1 more person in because I feel this task can be done in parallel.

[melvin-bot]

@Kicu, @luacmartins, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search v2] Add displaying advanced filter values and type/status #46022

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[sonialiap]

Payment summary:

• @rayane-djouah $250 - offer sent in Upwork - paid ✔️

[rayane-djouah]

Offer accepted, thanks!

[rayane-djouah]

No need for regression test steps for now; they will be added as part of the project.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @Kicu is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sonialiap]

Paid ✔️