Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Free trial] [FE] Remove name and permissions from sNVP #45031

Closed
chiragsalian opened this issue Jul 8, 2024 · 0 comments
Closed

[Free trial] [FE] Remove name and permissions from sNVP #45031

chiragsalian opened this issue Jul 8, 2024 · 0 comments
Assignees
@chiragsalian
Labels
Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@chiragsalian
Copy link
Contributor

Problem

We had a bit of back and forth wrt sNVP format and as per the latest discussion here we'll only return value in JSON format and not include the name and permissions.

Why is this important?

We cleaned this up in the auth layer and now its best to clean up the front end as well.

Solution

Remove name and permission reference from sNVP BillingGraceEndPeriod.
@chiragsalian chiragsalian added Daily KSv2 Improvement Item broken or needs improvement. labels Jul 8, 2024
@chiragsalian chiragsalian self-assigned this Jul 8, 2024
@chiragsalian chiragsalian mentioned this issue Jul 8, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 9, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiragsalian chiragsalian

Labels
Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chiragsalian