Report fields - All report fields disappear instead of crossed out when deleted offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields
3. Add a few report fields
4. Go offline
5. Delete all the report fields

Expected Result:

The report fields should be crossed out when all the report fields are deleted offline (production behavior)

Actual Result:

The report field list is empty when all the report fields are deleted offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537872_1720617440034.report_fields.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report field list is empty when all the report fields are deleted offline

What is the root cause of that problem?

We show the empty state if all report fields has pendingAction is deleted

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Lines 130 to 132 in 97b3831

	const shouldShowEmptyState =
	Object.values(filteredPolicyFieldList).filter((reportField) => reportField.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE).length <= 0 && !isLoading;

What changes do you think we should make in order to solve the problem?

We should check if the network is offline, we will not show the empty state if we have pending delete report fields as we do in other pages like category pages here

const shouldShowEmptyState =
        Object.values(filteredPolicyFieldList).filter((reportField) => reportField.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline).length <= 0 && !isLoading;

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Lines 130 to 132 in 97b3831

	const shouldShowEmptyState =
	Object.values(filteredPolicyFieldList).filter((reportField) => reportField.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE).length <= 0 && !isLoading;

What alternative solutions did you explore? (Optional)

[rushatgabhane]

PR reviewed