Accounting - Non-reimbursable expense becomes empty after going offline and online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44921

Action Performed:

Pre-requisite

• Collect workspace with accounting enabled.
• NetSuite beta enabled for the user. (Use expensifail account)
• Setup NetSuite in OldDot.

1. Open the app with the pre-setup workspace.
2. Go to Accounting
3. Click on the Advanced button.
4. Click on Non-reimbursable expense option (Enable Custom form ID to access this field)
5. Input any number and confirm
6. Wait a few seconds and go offline
7. Go back online again

Expected Result:

The value in Non-reimbursable expense persists

Actual Result:

The value in Non-reimbursable expense becomes empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538055_1720626623688.bandicam_2024-07-10_18-45-35-410.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Gonals]

Hmm. This looks like a backend issue, at first glance. Can it be reproduced consistently?

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Gonals]

Ok, that field is not working at all. It is not a blocker, as this is new functionality and doesn't break any existing stuff, but we need to fix it. I'll look more into it today/tomorrow

[Gonals]

Yeeep. This is a typo in the backend. Fix incoming

[Christinadobrzyn]

I assume we can move this from hourly to daily now that a PR is in the works. @Gonals does that sound okay?

[Gonals]

Yep!

[Christinadobrzyn]

Update for Melvin- working on PR https://github.com/Expensify/Web-Expensify/pull/42707

[Christinadobrzyn]

I think I'm going to move this to weekly since we're working on PR - https://github.com/Expensify/Web-Expensify/pull/42707

[Christinadobrzyn]

PR is in production - https://github.com/Expensify/Web-Expensify/pull/42707 as of the 16th. Can we close this out @Gonals and @lakchote?

[Christinadobrzyn]

I'm going to close this out. We can reopen if needed.