Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBO - Previous tags reappear when returning online after editing #45194

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 10, 2024 · 7 comments
Closed
1 of 6 tasks

QBO - Previous tags reappear when returning online after editing #45194

lanitochka17 opened this issue Jul 10, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+shch1@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause - Internal Team

Issue found when executing PR #44441

Action Performed:

Workspace is connected to QBO

  1. Go to staging.new.expensify.com
  2. Go to workspace settings
  3. Go to Tags
  4. Go offline
  5. Click on any tag (Classes or Customers/Projects)
  6. Edit the tag name or edit any subtag
  7. Click Back button
  8. Return back to online

Expected Result:

Tags should display the updated edits when returning online after editing offline

Actual Result:

Previous tags reappear when returning online after editing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538098_1720628758593.2024-07-10_21-11-38.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@alexpensify
Copy link
Contributor

Ok, adding to my testing list.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 12, 2024
@alexpensify
Copy link
Contributor

No update, I'll test soon

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 15, 2024
@alexpensify
Copy link
Contributor

Other GHs have been a priority, I'll review soon

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 17, 2024
@alexpensify
Copy link
Contributor

Closing: After reviewing in more detail, the category or tag names from a direct integration like QBO should not be editable. If anything, we could maybe block this option if in offline mode to avoid confusion. For now, I'm closing.

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants