Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid app - Explanation modal appears every time app opened #45254

Closed
2 of 6 tasks
izarutskaya opened this issue Jul 11, 2024 · 9 comments
Closed
2 of 6 tasks

Hybrid app - Explanation modal appears every time app opened #45254

izarutskaya opened this issue Jul 11, 2024 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6.0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44903
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: on web create a new account in OD and run the snippet to enable the Try New Expensify button

  1. Log in with the account that has the Try New Expensify button enabled into Expensify classic app
  2. Tap the hamburger menu
  3. Select the Try New Expensify option
  4. Complete the onboarding
  5. Kill the app and open again

Expected Result:

The explanation modal opens only once

Actual Result:

The explanation modal appears after completing onboarding and every time the app is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6538630_1720678461591.video_2024-07-11_02-07-48.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@rlinoz
Copy link
Contributor

rlinoz commented Jul 11, 2024

Yeah, this is most likely caused by #44903

cc: @mateuuszzzzz @AndrewGable

We don't seem to have changed anything related in Web-E, so I am gonna remove the blocker label.

@rlinoz rlinoz removed the DeployBlocker Indicates it should block deploying the API label Jul 11, 2024
@Julesssss
Copy link
Contributor

Dupe of #44701

@Julesssss
Copy link
Contributor

Not an blocker. This is a known Hybrid app issue.

@OfstadC
Copy link
Contributor

OfstadC commented Jul 11, 2024

Thanks @Julesssss and @rlinoz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants