Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] New account - Onboarding messages aren't present when selecting "Something else" in the modal #45455

Closed
1 of 6 tasks
izarutskaya opened this issue Jul 16, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #45248
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/

  2. Lig in with a new Gmail account

  3. Choose "Something else" in the onboarding modal

  4. Input any first and last name and click on the "Continue" button

  5. Open Chrome console

  6. Paste and run "Onyx.log('nvp_onboarding');"

  7. Copy the received chatReportID from the console

  8. Paste it after the last "/" in the link and navigate to it: https://staging.new.expensify.com/r/

Expected Result:

Onboarding messages should be visible.

Actual Result:

Onboarding messages aren't present when selecting "Something else" in the modal. They're visible for all of the other onboarding options.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6543496_1721107066759.bandicam_2024-07-16_07-09-48-239.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ec9d2ec7c34c29b9
  • Upwork Job ID: 1813236871020557880
  • Last Price Increase: 2024-07-16
Issue OwnerCurrent Issue Owner: @rushatgabhane
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@iwiznia
Copy link
Contributor

iwiznia commented Jul 16, 2024

I can reproduce this in dev

@iwiznia
Copy link
Contributor

iwiznia commented Jul 16, 2024

Hmmm wait, but I can also reproduce on prod... is this the message that I am not supposed to be seeing?
image

(asked in slack too https://expensify.slack.com/archives/C9YU7BX5M/p1721138144095149)

@kavimuru
Copy link

@iwiznia In step 6

Paste and run "Onyx.log('nvp_onboarding');

"Onyx.log('nvp_onboarding'); returns with an error in production, but onboarding message is not present for both production and staging when selecting "Something else" option.

@iwiznia
Copy link
Contributor

iwiznia commented Jul 16, 2024

Seems this was triggered when testing #45248 since the script does not work on prod cc @rojiphil @chiragsalian

Not a blocker though

@iwiznia iwiznia added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Jul 16, 2024
@iwiznia iwiznia removed their assignment Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ec9d2ec7c34c29b9

@melvin-bot melvin-bot bot changed the title New account - Onboarding messages aren't present when selecting "Something else" in the modal [$250] New account - Onboarding messages aren't present when selecting "Something else" in the modal Jul 16, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@trjExpensify
Copy link
Contributor

I'm still confused.

Onboarding messages aren't present when selecting "Something else" in the modal. They're visible for all of the other onboarding options.

There aren't any onboarding tasks when that onboarding intent is selected, so I wouldn't expect any.

@rojiphil
Copy link
Contributor

Onboarding messages aren't present when selecting "Something else" in the modal.

I also think this is expected.

But what I don't understand is They're visible for all of the other onboarding options.
My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses
@trjExpensify @chiragsalian Is this understanding correct?

@trjExpensify
Copy link
Contributor

My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses

Nah, there's tasks for different onboarding intents. Just not the "something else" option. You have access to the doc already to check out the UI of those if you're interested.

@rojiphil
Copy link
Contributor

My understanding is that onboarding messages are shown only when we have a workspace i.e. via Manage my team's expenses

Nah, there's tasks for different onboarding intents. Just not the "something else" option. You have access to the doc already to check out the UI of those if you're interested.

Oh shoot! I got confused with the term Onboarding messages. Thanks for pointing out the document.

@rojiphil
Copy link
Contributor

Can we close this issue please if there is nothing to be fixed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants