-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Search - App closes RHP instead of returning to report after deleting expense with comments #45505
Comments
Triggered auto assignment to @neil-marcellini ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 1 |
Job added to Upwork: https://www.upwork.com/jobs/~0137d82e1685ebf8ce |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura ( |
@jasperhuangg I found that this was modified recently by the PR associated with this issue [$250] Expense - Inconsistency in dismissing report details RHP when deleting expense with comments. I think the current staging behavior might be expected now, but I'm unsure. What do you think? Re-assigning to you since you managed that issue. |
@neil-marcellini Good shout, I think this is the new expected behavior now. @lanitochka17 Are there any integration tests that we need to update? |
Yeah, this was agreed in the previous issue to close the details page when deleting a transaction, so we use |
@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@bernhardoj No worries, I think if we agreed in the other issue then that should be the new expected behavior. I'll reach out to QA in Slack about updating the regression test. |
Relevant Slack thread for updating regression tests is here |
Bumped the thread |
Resolved in the Slack thread |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause -Internal Team
Action Performed:
Expected Result:
App will return to the transaction thread with comments
Actual Result:
App closes the RHP completely
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6543949_1721135646891.20240716_210901.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @paultsimuraThe text was updated successfully, but these errors were encountered: