Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xero -"manually exported" message only appears after revisting export and it is missing "Xero" #45594

Closed
6 tasks done
izarutskaya opened this issue Jul 17, 2024 · 11 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #44170
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Admin and employee are in the same workspace.
  • Workspace is connected to Xero.
  1. Go to staging.new.expensify.com
  2. [Employee] Submit an expense in the workspace chat.
  3. [Admin] Go to workspace chat with employee.
  4. [Admin] Click on the expense preview.
  5. [Admin] Pay elsewhere the report.
  6. [Admin] Click "Mark manually as entered" button.

Expected Result:

  • "manually exported" system message will show up in report without revisiting the report.
  • "manually exported" system message will be complete.

Actual Result:

  • "manually exported" system message only shows up in report after revisiting the report.
  • "marked this report as manually exported to " system message is missing "Xero".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6544833_1721204151988.20240717_161123.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 17, 2024

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production
Screenshot 2024-07-17 144239

@MariaHCD
Copy link
Contributor

Hmm, looks like we noticed that the name of the platform is missing before we merged the PR: #44170 (comment)

But we can potentially ignore this for now? #44170 (comment)

cc: @arosiclair @francoisl

@kosmydel
Copy link
Contributor

I think we can ignore it for now. It was noticed here, and we have decided that the issue is the backend side here.

@MariaHCD
Copy link
Contributor

Cool, this doesn't need to block the deploy, then.

@arosiclair @francoisl Do we have an issue to track the BE fix?

@MariaHCD MariaHCD added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jul 17, 2024
@arosiclair
Copy link
Contributor

@arosiclair @francoisl Do we have an issue to track the BE fix?

I don't think so. Let's use this one to track it. I'll take over cc @lakchote as well

@arosiclair arosiclair assigned arosiclair and unassigned MariaHCD Jul 17, 2024
@arosiclair
Copy link
Contributor

Alright this is happening because I forgot to add EXPORTINTEGRATION to our list of actions we queue onyx updates for here. I'll post a PR to fix that

@arosiclair
Copy link
Contributor

PR hit prod last week. This is all set.

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants