[$250] Android - Track expense - Error displayed when track distance expense in self DM

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7.4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found whn executing PR #43819

Action Performed:

1. Open the app and log in
2. Open the self Dm
3. Tap + > Track expense > Distance
4. Enter two viewpoints and create an expense
5. Open the created expense

Expected Result:

There is no error after creating an expense, and the distance field shows the vlaue

Actual Result:

The distance field shows pending, and after some the error "Unexpected error submitting expense. Please try again later" is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6544115_1721144599207.video_2024-07-16_11-43-10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a00f0f0391819080
• Upwork Job ID: 1814324563707246828
• Last Price Increase: 2024-08-09

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a00f0f0391819080

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

@abekkala, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kabeer95]

Proposal

Problem Statement Please re-state the problem that we are trying to solve in this issue:

When a user tries to track distance expense in self DM, an error is displayed.

Root Cause What is the root cause of that problem:

The root cause of this problem is that the code is not properly handling the submission of distance expenses in Direct Messages.

Proposed Solution

What changes do you think we should make in order to solve the problem: To solve this problem, I propose modifying the ExpenseList.js file to ensure that the map function is only called if expenses is defined and not undefined. Additionally, I suggest modifying the App.js file to properly handle the response from the server and add error handling.

Changes What changes do you think we should make in order to solve the problem:

In the ExpenseList.js file, replace the following line:

{expenses.map((expense, index) => (

with:

{expenses && expenses.map((expense, index) => (

In the App.js file, ensure that the fetchExpenses function is properly handling the response from the server. This may involve adding error handling or modifying the response parsing logic.

Solution Code

Here is the code that can solve the problem:

In the ExpenseList.js file:

{expenses && expenses.map((expense, index) => (
  <ExpenseItem
    key={index}
    expense={expense}
    onPress={() => selectExpense(expense)}
  />
))}

In the App.js file:

const fetchExpenses = async () => {
  try {
    const response = await fetch(
      `https://expensify-api.herokuapp.com/api/expenses`
    );
    const data = await response.json();
    setExpenses(data);
  } catch (error) {
    console.error(error);
  }
};

[rushatgabhane]

The root cause of this problem is that the code is not properly handling the submission of distance

@kabeer95 sorry I do not understand the root cause. Could you please elaborate it?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@abekkala, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@kabeer95 can you address the question above from @rushatgabhane and elaborate on your comment

[melvin-bot]

@abekkala, @rushatgabhane Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@abekkala @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@abekkala, @rushatgabhane 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@abekkala, @rushatgabhane 12 days overdue now... This issue's end is nigh!

[abekkala]

let's get this one retested

[melvin-bot]

This issue has not been updated in over 14 days. @abekkala, @rushatgabhane eroding to Weekly issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abekkala]

this is for VSB which is on hold - closing
not a priority