Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Distance - Center button does not return to the current location (blue dot) #45693

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 18, 2024 · 21 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44752

Action Performed:

  1. Launch New Expensify app
  2. Go to FAB > Submit expense > Distance
  3. Swipe on the map to navigate away from the current location (blue dot)
  4. Tap on the center button

Expected Result:

Map will return to the current location (blue dot)

Actual Result:

Center button does not return to the current location (blue dot)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546267_1721314309161.1721314126841_Screen_Recording_20240718_224827_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0103b94842fb8e973f
  • Upwork Job ID: 1814001263862473865
  • Last Price Increase: 2024-07-18
Issue OwnerCurrent Issue Owner: @ishpaul777
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

This is an annoying one, can't repro on emulator but reproducible in a physical device.

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Oh it is not reproducible in the dev build actually...

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Testing if reverting the PR works #45707

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Humm didn't fix the issue, let me add the help wanted label.

@rlinoz rlinoz added the External Added to denote the issue can be worked on by a contributor label Jul 18, 2024
@melvin-bot melvin-bot bot changed the title Android - Distance - Center button does not return to the current location (blue dot) [$250] Android - Distance - Center button does not return to the current location (blue dot) Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0103b94842fb8e973f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Oh it is probably this #45575

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jul 18, 2024

Submit expense flow is broken on latest main i get not found screen on all type request, i am not even able to reproduce becuase of this

Screenshot 2024-07-19 at 12 16 34 AM

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Yeah, that is new

@thienlnam thienlnam removed the DeployBlocker Indicates it should block deploying the API label Jul 18, 2024
@thienlnam
Copy link
Contributor

Removing the DeployBlocker label since it doesn't appear to be related to the API

@HaroonLiaqat
Copy link

GeoLoxation service if react native provides us the current location's longitude and latitude. We should store its value in a state variable. The map reference provides us a method to jump on a particular location. We can pass our current location to that method through ref if map

Copy link

melvin-bot bot commented Jul 18, 2024

📣 @HaroonLiaqat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@HaroonLiaqat
Copy link

GeoLoxation service if react native provides us the current location's longitude and latitude. We should store its value in a state variable. The map reference provides us a method to jump on a particular location. We can pass our current location to that method through ref if map

Haroon Liaqat (react native developer)
Your Expensify account email: haroonliaqat.dev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01753b23816630ae84

@rlinoz
Copy link
Contributor

rlinoz commented Jul 18, 2024

Running a new build here #45726 to check if reverting that PR fixes it.

@rlinoz
Copy link
Contributor

rlinoz commented Jul 19, 2024

Hmmm actually we cant click anything in that screen:

VIDEO-2024-07-19-10-44-17.mp4

@rlinoz
Copy link
Contributor

rlinoz commented Jul 19, 2024

ok locally it looks like reverting the version of react-native-pager-view works #45573, let me try a revert pr

@rlinoz
Copy link
Contributor

rlinoz commented Jul 19, 2024

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 19, 2024
@ishpaul777 ishpaul777 removed their assignment Jul 19, 2024
@ishpaul777
Copy link
Contributor

i was not invoived in PR, No payment necessary

@rlinoz rlinoz closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants