[Free Trial] Make the "Add payment card" button redirect to settings/subscription/add-payment-card so the RHP opens

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.8-1
Reproducible in staging?: Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1721181508995759?thread_ts=1721057227.335969&cid=C036QM0SLJK

Action Performed:

1. Create a workspace
2. Submit an expense to the workspace to start a free trial
3. Go to supportal and set the free trial date to a date in the past (to faux it being ended)
4. Go to the "Free trial has ended" message in the Expensify/Conci DM
5. Click the "Add payment card" button

Expected Result:

Redirected to settings/subscription/add-payment-card, so the RHP to add a payment card opens.

Actual Result:

Redirected to settings/subscription.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-07-17_02-57-39.mp4

View all open jobs on GitHub

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Make the "Add payment card" button redirect to settings/subscription/add-payment-card so the RHP opens

What is the root cause of that problem?

We need to update the navigation action here:

App/src/pages/home/report/ReportActionItem.tsx

Lines 408 to 411 in 6851dc1

	text: 'subscription.cardSection.addCardButton',
	key: `${action.reportActionID}-actionableAddPaymentCard-submit`,
	onPress: () => {
	Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION);

What changes do you think we should make in order to solve the problem?

We will update this line to:

Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD)

[chiragsalian]

Sorry I picked this up and already finished it internally since it was a quick fix for me.

[melvin-bot]

This issue has not been updated in over 15 days. @chiragsalian, @trjExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

No payment needed here, closing.