Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Hold option is missing from the dropdown #45837

Closed
6 tasks done
lanitochka17 opened this issue Jul 20, 2024 · 8 comments
Closed
6 tasks done

Search - Hold option is missing from the dropdown #45837

lanitochka17 opened this issue Jul 20, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45712

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense > Manual
  3. Submit a manual expense to any user
  4. Go to Search
  5. Click on the checkbox of the same transaction in Step 3
  6. Click on the dropdown

Expected Result:

There will be Hold option

Actual Result:

Hold option is missing from the dropdown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547753_1721442059183.45712_web.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 20, 2024
Copy link

melvin-bot bot commented Jul 20, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@gijoe0295
Copy link
Contributor

gijoe0295 commented Jul 20, 2024

I think this is expected. Hold is only available for unsettled workspace expenses.

@alexpensify
Copy link
Contributor

This was assigned over the weekend. I'll review it soon. Also, thanks @gijoe0295 for the feedback!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 22, 2024
@alexpensify
Copy link
Contributor

On my review list, I'll get to it soon.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 25, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@alexpensify
Copy link
Contributor

Closing - I'm unable to replicate the experience mentioned here.

2024-07-29_12-26-41

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants