[HOLD for payment 2024-08-14] [$250] [Payment card / Subscription] - Error message is not dismissed after entering text in the response field

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating #44763
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no this is new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• Account has collect workspace with an annual subscription.

1. Go to staging.new.expensify.com
2. Go to Subscription.
3. Click "Request early cancellation".
4. Without selecting a reason, click Submit.
5. Select a reason.
6. Note that the error message disappears.
7. Click Submit without entering response in the text field.
8. Enter response in the text field.

Expected Result:

The error message will be dismissed after entering text in the response field.

Actual Result:

The error message is not dismissed after entering text in the response field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552303_1721888812694.20240725_142320.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019378d79c0bd60aef
• Upwork Job ID: 1817975652284460058
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #wave-collect - Release2

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message is not dismissed after entering text in the response field

What is the root cause of that problem?

We just set the value and not hide the error message on text change here

What changes do you think we should make in order to solve the problem?

create handleSetNote function to set setShouldShowReasonError(false); and use it in onChangeText

    const handleSetNote = (text: string) => {
        setShouldShowReasonError(false);
        setNote(text);
    };

What alternative solutions did you explore? (Optional)

[MariaHCD]

This does not need to block the web deploy since this is a UX improvement

[francoisl]

This doesn't block from requesting the early cancelation so I don't think it's worth blocking on.

Screen.Recording.2024-07-25.at.10.59.59.AM.mov

cc @JKobrynski @blimpich as this likely comes from #44763

[blimpich]

Yeah I would consider this to be polish follow up for the PR @francoisl mentioned. I'll pick this up since I'm managing that project.

[blimpich]

@JKobrynski can you make a follow up PR for this?

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[trjExpensify]

Assigned!

[nyomanjyotisa]

I think my proposal supposed to be reviewed first? base on this:

App/contributingGuides/CONTRIBUTING.md

Line 152 in 6bc174f

- If there are existing proposals, BZ will put the issue on hold. [Contributor+](https://github.com/Expensify/App/blob/main/contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md) will review the existing proposals. If a contributor’s proposal is accepted then the contributor will be assigned to the issue. If not the issue will be assigned to the agency-employee.

[trjExpensify]

This is a regression follow-up from #44763 for which Julian authored. 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Payment card / Subscription] - Error message is not dismissed after entering text in the response field #46641

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allroundexperts]

Regression test

1. Sign in to an account that has a collect workspace with an annual subscription.
2. Go to Subscription and click "Request early cancellation".
3. Without selecting a reason, click Submit.
4. Verify that an error message appears.
5. Select a reason.
6. Verify that the error message disappears.
7. Click Submit without entering response in the text field.
8. Verify that an error appears.
9. Enter response in the text field.
10. Verify that the error message will be dismissed after entering text in the response field.

Do we 👍 or 👎 ?

[greg-schroeder]

This is a regression follow-up, so no payments are due in this issue tomorrow. I've filed the regression test above as well. Closing for now. Please reopen if I've missed anything.

[allroundexperts]

@greg-schroeder I was not involved in the previous issue (if there was any). I think my payment is pending here for the review.

[greg-schroeder]

payment summary:

@allroundexperts okay thanks! in that case you can make a manual request via ND for $250 for the reviewer role

[JmillsExpensify]

$250 approved for @allroundexperts