[Held requests] Held and unpaid expense disappears when paying only the unheld expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4775912
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to User B
3. [User A] Hold one of the submitted expenses
4. [User B] Go to expense report from User A
5. [User B] Click Pay button
6. [User B] Pay partially the expense (pay the unheld expense)

Expected Result:

For User A and B,

• the paid system message should display "paid elsewhere"
• the unpaid expense will be moved to a new report

Actual Result:

For User A and B,

• the paid system message displays "paid elsewhere"

For User A,

• the unpaid expense disappears.

For User B,

• the unpaid expense becomes negative in another report, and it leads to not here page.
• the unpaid expense disappears after clearing app cache and restarting app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554706_1722088302329.bandicam_2024-07-27_21-39-39-030.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d67b0d3a732826c4
• Upwork Job ID: 1821690332875199057
• Last Price Increase: 2024-08-15

Issue Owner

Current Issue Owner: @robertjchen

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[JmillsExpensify]

Going to highlight this one in the project issue.

[JmillsExpensify]

Flagged this in #wave-collect. I'll go ahead and add it to polish for now, though @trjExpensify we can remove depending on how the wave-collect/polish hit list pans out.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d67b0d3a732826c4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

@JmillsExpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dukenv0307]

@JmillsExpensify It's BE bug

[trjExpensify]

@dukenv0307 any more insight on that? CC: @robertjchen

[robertjchen]

Looks like the backend is not sending Onyx updates when something is being unheld as part of a payment/approval operation. Testing out some solutions locally to see if it'll help here.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify, @robertjchen, @dukenv0307 eroding to Weekly issue.

[robertjchen]

Discussing this one here

[trjExpensify]

Suggested next steps from @luacmartins in thread:

This is happening because we're moving an IOU expense to a new expense report, instead of an IOU report, because we call moveTransactionsToNewExpenseReport
we need to check if we're moving a transaction on iou or expense report and then move it to a new iou report instead

[robertjchen]

PR with fix for negative amounts with held expenses merged 👍 Finishing this off with the iou report moving issue

[robertjchen]

Draft PR has working flow in place, testing still in progress for the final optimistic updates. Should be ready to review before EOW

[robertjchen]

PR under review

[robertjchen]

FE PR under review

[robertjchen]

FE PR merged and on the way out

[robertjchen]

Tested and held IOUs no longer "disappear" off to an inaccessible policy 👍

Did come across two minor bugs coming off of the new flow- created new successor issues linked below:

• https://github.com/Expensify/Expensify/issues/430923
• [$250] [Held requests] Duplicate IOU created after partial payment #49689