[HOLD for payment 2024-08-14] [HybridApp] Onyx value miss-match triggering welcome modal

[Julesssss]

Problem

In some cases the Welcome Modal is being displayed due to the NVP not being read from Onyx correctly. It is hard to reproduce.

@JmillsExpensify is experiencing this.

Solution

Mateusz has a plan here.

[mateuuszzzzz]

Commenting to be assigned

[mateuuszzzzz]

Update:

From current investigations it seems like problem lies somewhere in Onyx (probably this is specific of HybridApp).
I reproduced the bug using emulator which is not exactly the same as Jason's environment. Nevertheless, I think we experience the same thing and origin is very similar or even the same.

It's hard to verify the real root cause without Jason's logs so I'm gonna need them at some point.

I think that since we cannot rely on Onyx in this case we can always fallback to values from OldDot. This should simplify the logic a bit. At the moment we have two sources of completedHybridAppOnboarding which is OldDot NVP and NewDot Onyx.
I'm testing fix where we have native method that returns OldDot's NVP value. In this case we should be able to get rid of Onyx for this specific nvp.

[mateuuszzzzz]

I should be able to prepare PR today. Actually 2 PRs, because fix changes some logic on OD and ND. Then I assume we can create ad hoc build for Jason to make sure that it fixed the problem on his device.

EDIT: I created drafts https://github.com/Expensify/Mobile-Expensify/pull/12899 and #46603 but I have one more hypothesis that the bug might be related to the change of component that Explanation Modal uses underneath (initially we were using slightly different implementation). In order to verify it I'm gonna need Jason's logs and current values of his tryNewDot NVP.

[mateuuszzzzz]

After verification of Jason's NVP it looks like we can introduce simpler fix. I'll prepare PR tomorrow

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [HybridApp] Adjust props of explanation modal #46704

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mateuuszzzzz does not require payment (Contractor)

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@mateuuszzzzz Huh... This is 4 days overdue. Who can take care of this?