Workspace - Back button returns to the same workspace page after upgrading to Control

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #45730
Version Number: 9.0.14-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to More features.
4. Toggle on Report fields.
5. Click Upgrade.
6. Click Got it, thanks.
7. Click on the app back button.

Expected Result:

App will return to workspace list page (previous page).

Actual Result:

App returns to the same workspace editor page, which is from More features back to More features page again.

On prod, the back button works correctly as it returns from Profile to More features page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6556599_1722282753369.20240730_035010.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[chiragsalian]

Doesn't look web-e related. removing deployblocker label.

[aldo-expensify]

I see that in production it takes you automatically to the workspace's Profile page after the upgrade:

Screen.Recording.2024-07-29.at.2.49.24.PM.mov

This doesn't happen in the recording from this issue

[aldo-expensify]

I think this is happening because of this PR: https://github.com/Expensify/App/pull/45730/files

[aldo-expensify]

cc @allroundexperts @rushatgabhane

[aldo-expensify]

I think this works well if you scrolled down to find Report fields inside More features, because then the Back button will scroll you down to where you were when you clicked Report fields and a second click will take you out to the Profile:

Screen.Recording.2024-07-29.at.3.06.01.PM.mov

but, if you didn't scroll down to find the Report fields, then the first press on the back button will not move the scrollbar making it look like it did nothing:

Screen.Recording.2024-07-29.at.3.06.47.PM.mov

[aldo-expensify]

I think the easiest fix is that we should NOT do any navigation when we upgrade in this flow. We are currently scrolling up, but what for?

[aldo-expensify]

Creating a revert here since I'm not sure what is the right way to fix this and the transition also doesn't look good: #46460

[allroundexperts]

Hm... Is a revert really needed here? Asking because this PR fixes issues which might be of greater importance than this bug.

[aldo-expensify]

Hm... Is a revert really needed here? Asking because this PR fixes issues which might be of greater importance than this bug.

Do you have some examples? I'm just suggesting a revert because I didn't see it fixing something of importance, I don't have a clear solution for this deploy blocker, and the animation here looks broken #45730 (comment)

Feel free to suggest a solution without reverting. Ah, the revert was merged, too late.

[aldo-expensify]

Reverted and tested: #46460