Chat - Different placement of sender name and message on staging vs production

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message.
4. Compare the placement of sender name and message on staging and production.

Expected Result:

The placement of sender name and message on staging will be the same as that on production.

Actual Result:

The placement of sender name and message on staging is different from production.
On staging, there is some spacing between sender name and message.
The sender name is also a bit lower compared to production.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6556720_1722287856118.20240730_051442.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[izarutskaya]

Production

[gijoe0295]

Offending PR: #40692 at this line:

App/src/styles/index.ts

Line 2060 in fdd2385

lineHeight: variables.lineHeightXXLarge,

[parasharrajat]

I don't think this counts as a regression. It is intentional change. @VickyStash

[VickyStash]

I don't think this counts as a regression. It is intentional change. @VickyStash

Yeah, otherwise, there were problems with the date alignment on web platforms or emojis cut off on ios for names with emojis

[shawnborton]

Hmm we do not want to be changing the line height across the app like this though, notice how in the bug report above we now have a space under the sender name. I think we need to revert the offending PR.

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1722351467920939

There's a revert here #46463 and a potential fix here #46478 and both are getting adhoc builds to test them out.

[parasharrajat]

We will have to rethink of a better solution in that case.

[roryabraham]

#46463 was reverted, so let's retest this on staging...

[roryabraham]

easy enough, confirmed this is fixed