[HOLD for payment 2024-08-19] Suggestions causing excessive updates

[hannojg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:v9.0.16-4 Develop
Reproducible in staging?: No, but there no warning will be thrown, although the performance impact is there
Reproducible in production?: No, but there no warning will be thrown, although the performance impact is there
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:@hannojg
Slack conversation:

Action Performed:

• Open the native mobile app in development mode
• Type rapidly into the composer spamming ~80 characters
• In dev mode a warning will popup warning about excessive re-renders

Expected Result:

None of our components rerenders excessively while typing.

Actual Result:

Although there are no visible changes, internally we queue lots of react state updates.

Workaround:

No, its more of a performance issue.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-19.at.19.11.12.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@neil-marcellini Since I reviewed the PR, can you please assign me to this issue? TIA 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: suggestions causing excessive updates #45789

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
• [@neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hannojg] Determine if we should create a regression test for this bug.
• [@hannojg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hannojg]

I think no regression test is needed, this is only something that can come up during development

[twisterdotcom]

Let's close now then, no payment, no regression tests needed.

[hungvu193]

Let's close now then, no payment, no regression tests needed.

I think there will be payment left for me. I reviewed the PR

[twisterdotcom]

Ah, you're right! Sorry for missing that @hungvu193.

[twisterdotcom]

Payment Summary:

• @hungvu193 paid $250 via newDot requests (C+)
• @hannojg does not require payment (Contractor)

[JmillsExpensify]

$250 approved for @hungvu193