-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - Attachment - App crashes when pasting an image from Google app (not Chrome browser) #47065
Comments
Triggered auto assignment to @puneetlath ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-vsp |
Seems unrelated to the API so removing the DeployBlocker label |
Seems pretty edge case to me... this currently works on production? Or is it not possible to test because we can't paste at all? Seems like the latter: #45722 |
cc @s77rt |
Hmm I'm not totally sure how I can test this on the Simulator. Can we get the error report? |
Created #47110 so this doesn't have to block deploy, but yes I'll also try to track down the crash report for you. Jury's out whether it will be of any use |
Can be demote this to not a blocker since it's a feature that didn't exist? And it seems to be an edge case |
I agree it's an edge case, but imo a non-critical new feature causing a crash should be treated as a blocker. especially since we don't really know the root cause, there might be other instances that we haven't discovered. We'd rather users not be able to paste images than to have their app crash when they try. |
waiting for an approval on #47114 to complete the CP |
Should be fixed in 9.0.18-7: https://github.com/Expensify/App/actions/runs/10311017716 |
I think given that this flow is very specific to the Google app and that reverting didn't solve the issue we should demote it for now. Gonna do that. |
Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new. |
Still reproducible RPReplay_Final1723233156.MP4 |
#47114 didn't include the removal of the RN patch |
@s77rt I don't totally follow. What does that mean needs to be done? |
@puneetlath If this is still reproducible then I think we should just wait for #47203 to hit staging |
issue is fixed ScreenRecording_08-16-2024.20-27-00_1.MP4 |
Great, thanks for confirming! Going to go ahead and close out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
App will not crash
Actual Result:
App crashes
This issue only happens when the image is copied from Google app, and not Chrome or Safari browser
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6565053_1723106856603.ScreenRecording_08-08-2024_16-44-36_1.mp4
Bug6565053_1723106856603.ScreenRecording_08-08-2024_16-44-36_1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: