Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Attachment - App crashes when pasting an image from Google app (not Chrome browser) #47065

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 8, 2024 · 21 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Google app is installed on the iOS device
  • Google search widget is added to the home screen
  1. Open Google search widget from the home screen
  2. Search for an image
  3. Long press on the image and copy it
  4. Launch New Expensify app
  5. Go to chat
  6. Paste the image

Expected Result:

App will not crash

Actual Result:

App crashes
This issue only happens when the image is copied from Google app, and not Chrome or Safari browser

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565053_1723106856603.ScreenRecording_08-08-2024_16-44-36_1.mp4
Bug6565053_1723106856603.ScreenRecording_08-08-2024_16-44-36_1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@marcaaron marcaaron removed the DeployBlocker Indicates it should block deploying the API label Aug 8, 2024
@marcaaron
Copy link
Contributor

Seems unrelated to the API so removing the DeployBlocker label

@marcaaron
Copy link
Contributor

This issue only happens when the image is copied from Google app, and not Chrome or Safari browser

Seems pretty edge case to me... this currently works on production? Or is it not possible to test because we can't paste at all?

Seems like the latter: #45722

@roryabraham
Copy link
Contributor

cc @s77rt

@s77rt
Copy link
Contributor

s77rt commented Aug 8, 2024

Hmm I'm not totally sure how I can test this on the Simulator. Can we get the error report?

@roryabraham
Copy link
Contributor

Created #47110 so this doesn't have to block deploy, but yes I'll also try to track down the crash report for you. Jury's out whether it will be of any use

@s77rt
Copy link
Contributor

s77rt commented Aug 8, 2024

Can be demote this to not a blocker since it's a feature that didn't exist? And it seems to be an edge case

@roryabraham
Copy link
Contributor

I agree it's an edge case, but imo a non-critical new feature causing a crash should be treated as a blocker. especially since we don't really know the root cause, there might be other instances that we haven't discovered. We'd rather users not be able to paste images than to have their app crash when they try.

@roryabraham
Copy link
Contributor

waiting for an approval on #47114 to complete the CP

@roryabraham
Copy link
Contributor

Should be fixed in 9.0.18-7: https://github.com/Expensify/App/actions/runs/10311017716

@marcaaron
Copy link
Contributor

I think given that this flow is very specific to the Google app and that reverting didn't solve the issue we should demote it for now. Gonna do that.

@marcaaron marcaaron added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

@m-natarajan
Copy link

Still reproducible

RPReplay_Final1723233156.MP4

@s77rt
Copy link
Contributor

s77rt commented Aug 10, 2024

#47114 didn't include the removal of the RN patch

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@puneetlath
Copy link
Contributor

@s77rt I don't totally follow. What does that mean needs to be done?

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
@s77rt
Copy link
Contributor

s77rt commented Aug 13, 2024

@puneetlath If this is still reproducible then I think we should just wait for #47203 to hit staging

@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
@mvtglobally
Copy link

issue is fixed

ScreenRecording_08-16-2024.20-27-00_1.MP4

@puneetlath
Copy link
Contributor

Great, thanks for confirming! Going to go ahead and close out.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@mvtglobally
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants