Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Merge Account to NewExpensify #47073

Open
7 of 19 tasks
zanyrenney opened this issue Aug 8, 2024 · 55 comments
Open
7 of 19 tasks

Add Merge Account to NewExpensify #47073

zanyrenney opened this issue Aug 8, 2024 · 55 comments
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item. Planning Changes still in the thought process Task

Comments

@zanyrenney
Copy link
Contributor

zanyrenney commented Aug 8, 2024

DESIGN DOC ➡️

Proposal

Tasks

  • Post Proposal (full Problem/Solution statement) in #whatsnext
  • Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
  • Paste Proposal in the space above with a link to the Slack thread
  • Email strategy@expensify.com and paste in the Proposal
  • Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section.
  • Fill out the High-level overview of the problem, Timeline, Terminology, and High-level of proposed solution sections of the Design Doc
  • Email strategy@expensify.com (continue the same email chain as before - your last message should be the WN Proposal) with the link to your Design Doc containing your high-level problem and solution
  • Add the DesignDocReview label to get the High-level overview of the problem and High-level of proposed solution section reviewed
  • Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
  • Fill out the Detailed implementation of the solution and related sections.
  • Re-add the DesignDocReview label to this issue
  • Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Email strategy@expensify.com one last time to let them know the Design Doc is moving into the implementation phase
  • Implement the changes
  • Add regression tests so that QA can test your feature with every deploy (instructions)
  • Send out a follow up email to strategy@expensify.com once everything has been implemented and do a Project Wrap-Up retrospective that provides:
    • Summary of what we accomplished with this project
    • What went well?
    • What could we have done better?
    • What did we learn?
@zanyrenney zanyrenney added Daily KSv2 Planning Changes still in the thought process NewFeature Something to build that is a new item. Task labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Current assignees @twisterdotcom and @zanyrenney are eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@zanyrenney
Copy link
Contributor Author

zanyrenney commented Aug 12, 2024

Edited by proposal-police: This proposal was edited at 2024-08-19 15:59:41 UTC.

Need to improve this but startign with the P/S

Proposal: add the remaining account settings to new dot, Part 1: Merge Account (Part 2: Device Management TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

  • Re-scan their receipts using their company account.
  • Manually create expenses within their company account.
  • Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts.

@zanyrenney
Copy link
Contributor Author

Pre-design on merging accounts for workspace feed/card conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1723841346915409

@zanyrenney
Copy link
Contributor Author

zanyrenney commented Aug 19, 2024

Proposal: Add the remaining account settings to NewExpensify.

Part 1: Merge Account
Part 2: Consider implications for this on Device Management (TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

  • Re-scan their receipts using their company account.
  • Manually create expenses within their company account.
  • Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts, and crucially, give them the ability to do take this action without requiring access to Expensify Classic.

Copy link
Contributor

@zanyrenney Your proposal will be dismissed because you did not follow the proposal template.

@zanyrenney
Copy link
Contributor Author

This is a bit mean, I haven't even done it yet 🥲

@zanyrenney
Copy link
Contributor Author

@zanyrenney
Copy link
Contributor Author

Not sure we need @dannymcclain here yet so will remove this from clogging up his K2.

@zanyrenney
Copy link
Contributor Author

2024-08-20_17-35-28

@zanyrenney
Copy link
Contributor Author

@twisterdotcom and I considered getting the pre-design out today or tomorrow but I realised we need to email strat@ prior, so done that and then can get the pre-design in flight!

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2024
@twisterdotcom
Copy link
Contributor

Back from some OOO. @zanyrenney has been predesigning in a canvas in my absence.

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2024
@zanyrenney
Copy link
Contributor Author

@zanyrenney zanyrenney added Daily KSv2 and removed Weekly KSv2 labels Sep 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 24, 2024
@bondydaa
Copy link
Contributor

okay think data storage / api changes is all set for now, at least I've tried to document where I wasn't sure and can hopefully get the feedback from the team then to get to the right spot. I resolved the rest of the outstanding items i had open and left some suggestions for @zanyrenney on that last remaining question you'd tagged me in.

I think we're in a good spot to send it out once you review those suggestions.

@zanyrenney
Copy link
Contributor Author

woooo!

Copy link

melvin-bot bot commented Sep 25, 2024

👋 Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Check out this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 panel or follow these instructions.


@zanyrenney
Copy link
Contributor Author

2024-09-25_17-13-50

shipped!

@trentpetty
Copy link

I have read and reviewed this Design Doc!

2 similar comments
@flodnv
Copy link
Contributor

flodnv commented Sep 27, 2024

I have read and reviewed this Design Doc!

@CortneyOfstad
Copy link
Contributor

I have read and reviewed this Design Doc!

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2024
@danielrvidal
Copy link
Contributor

I have read and reviewed this Design Doc!

1 similar comment
@AndrewGable
Copy link
Contributor

I have read and reviewed this Design Doc!

@bondydaa
Copy link
Contributor

doc is in review and comments are being addressed

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 27, 2024
@twisterdotcom
Copy link
Contributor

Same as Friday. It's in review.

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@isabelastisser
Copy link
Contributor

I have read and reviewed this Design Doc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item. Planning Changes still in the thought process Task
Projects
Status: Release 3: Fall 2024 (Nov)
Development

No branches or pull requests