[HOLD for #46838] Room - User details page can't be opened from members list

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.19-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2654638
Issue reported by: Applause Internal Team

Action Performed:

Precondition: #room conversation with at least 2 users, one that has a custom avatar and the other has a default avatar

1. Click on the header of the conversation
2. Click on Members
3. Click on the avatar in the user details page

Expected Result:

In the conversation viewer, when clicking on the avatar of any of the users, a modal with the user information should display. When interacting the avatar inside the user details modal, a full size view of the avatar should display.

Actual Result:

Clicking on user avatar leads to user select/unselect. User details page is not opened.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6570821_1723548555934.bandicam_2024-08-13_14-28-23-514.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - User details page can't be opened from members list

What is the root cause of that problem?

We are toggling user when onSelectRow is called.

App/src/pages/RoomMembersPage.tsx

Line 302 in 59741d8

onSelectRow={(item) => toggleUser(item)}

What changes do you think we should make in order to solve the problem?

Instead of toggling the use when onSelectRow is called, we should use onCheckboxPress to toggle user and use onSelectRow for opening members details page like we do in ReportParticipantsPage.

App/src/pages/ReportParticipantsPage.tsx

Lines 290 to 300 in 59741d8

	/** Opens the member details page */
	const openMemberDetails = useCallback(
	(item: MemberOption) => {
	if (isGroupChat && isCurrentUserAdmin) {
	Navigation.navigate(ROUTES.REPORT_PARTICIPANTS_DETAILS.getRoute(report.reportID, item.accountID));
	return;
	}
	Navigation.navigate(ROUTES.PROFILE.getRoute(item.accountID));
	},
	[report, isCurrentUserAdmin, isGroupChat],
	);

I think all users can access the participants details page but we can confirm the behaviour before implementing.

    const openMemberDetails = useCallback((item: ListItem) => {
        Navigation.navigate(ROUTES.PROFILE.getRoute(item?.accountID ?? ''));
    }, []);

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

I don't really understand how the expected and actual results are associated with the video. I'm going to ask the team for some clarifications on what is expected here.

https://expensify.slack.com/archives/C066HJM2CAZ/p1723565856002269

[Christinadobrzyn]

This will be resolved with #46838 and PR #47201.

I'm going to add a HOLD to this so we can test and make sure it's working as expected after #47201 is deployed.

[Christinadobrzyn]

monitoring PR - #47201

[Christinadobrzyn]

monitoring PR - #47201

[Christinadobrzyn]

monitoring PR - #47201

Heads up that I'll be ooo 9/4 - 9/10. I'm not going to assign a new BZ teammate to this as we're working on the PR. If you need a BZ teammate, please ping in slack.

[Christinadobrzyn]

monitoring PR - #47201

[Christinadobrzyn]

monitoring PR - #47201

[Christinadobrzyn]

This is resolved with #47201! Closing.