[Network] Messages are sending twice on staging desktop app

[marcaaron]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Send a comment

Expected Result:

Comment only appears once

Actual Result:

Comment is getting created multiple times in some scenarios

Workaround:

Yes, delete the extra comment I guess?

Platform:

Where is this issue occurring?

• Desktop App

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

I am checking if this is a side effect from My PR.

[parasharrajat]

I just checked this is not a side-effect from My PR. Network.post is being called two times when we are sending a single message. I am trying to figure out why this is being called twice.

EDit- Hold, I am still analysis so please think of the above statement as a conjecture.
I was wrong

[marcaaron]

Haha Ok I can try to look into this as well. I wasn't sure if the PR caused it or if it just did not fix the original problem - but clearly still happening on staging.

[isagoico]

We tested this on version 1.0.86-9 and it was a pass @marcaaron is this still happening on your side?

fixed.mp4

[marcaaron]

I think it must be due to an API issue or hard to reproduce. FWIW I haven't noticed it again in the staging app so we can remove the deploy blocker I think. But maybe can leave this open for a bit to track.

[kidroca]

I think I've found a cause and explained it here: #4214 (comment)

A developer should be able to confirm this

To reproduce consistently you can add some conditional code inside processNetworkQueue that will trigger a request through Network.post. This will in turn make a new call to processNetworkQueue before the first queue is over and before it had the chance to reset parameters

[madmax330]

Going to drop this back in the pool as I don't have time to look into it.

[marcaaron]

Gonna close this as it's a dupe of #4214