Invoices - App crashes after sending an invoice from FAB

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Send invoice
3. Enter amount > Next
4. Select a user > Next
5. Send the invoice

Expected Result:

App will not crash

Actual Result:

App crashes after sending an invoice from FAB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6580116_1724401370446.ScreenRecording_08-23-2024_17.mp4

logs (2).txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @tgolen

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[tgolen]

Thank you @VickyStash!

[VickyStash]

I've tried to reproduce the crash on different platforms and accounts and had no luck.

no_crash_11.mp4

no_crash_21.mp4

@lanitochka17 Do I miss anything?

[lanitochka17]

Issue is still reproducible on IOS

ScreenRecording_08-24-2024.01-41-06_1.MP4

[VickyStash]

@lanitochka17 It also works on iOS for me. Could you try to re-login to the account, will it be the same for you?

ios_recording1.mp4

[Nodebrute]

@tgolen Can I submit a proposal for this issue? I am able to repro.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes after sending an invoice from FAB

What is the root cause of that problem?

After we create a send invoice, IOURequestStepConfirmation can be unmounted after the draft transaction is reset then report?.policyID ?? policy?.id to be undefined

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 624 in f58439c

policyID={report?.policyID ?? policy?.id}

Then policyID prop here is an empty string by default that causes the app crash here since the OnyxKey change from policyDrafts_id to policyDrafts_

App/src/components/MoneyRequestConfirmationList.tsx

Line 196 in f58439c

policyID = '',

What changes do you think we should make in order to solve the problem?

We should use getIOURequestPolicyID function to get the policyID as we do here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 624 in f58439c

policyID={report?.policyID ?? policy?.id}

OPTIONAL: We can also fallback -1 here to prevent the same bug if we pass the empty string policyID to MoneyRequestConfirmationList

const [mileageRatesDraft] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${policyID || -1}`, { 
   selector: (selectedPolicy: OnyxEntry<OnyxTypes.Policy>) => DistanceRequestUtils.getMileageRates(selectedPolicy), 
}); 

App/src/components/MoneyRequestConfirmationList.tsx

Lines 215 to 218 in f58439c

	const [mileageRatesDraft] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${policyID}`, {
	selector: (selectedPolicy: OnyxEntry<OnyxTypes.Policy>) => DistanceRequestUtils.getMileageRates(selectedPolicy),
	});
	const mileageRates = isEmptyObject(mileageRatesReal) ? mileageRatesDraft : mileageRatesReal;

What alternative solutions did you explore? (Optional)

NA

[nkdengineer]

@VickyStash @tgolen I can reproduce this issue on the latest main on mWeb safari.

Screen.Recording.2024-08-26.at.15.29.38.mov

[VickyStash]

Good catch @nkdengineer! So it looks like this PR caused this regression, right?

[nkdengineer]

@VickyStash Yes.

[tgolen]

@dominictb Looks like #46859 caused the regression here so I will assign it to you. If you cannot write a fix today, then we'll need to revert that PR until a fix can be made. Are you able to submit a fix today?

[Nodebrute]

@tgolen We are encountering another crash on iOS that is easily reproducible when navigating between different chats. The crash occurs due to an existing iOS bug where setIsInputInitialized(true) is being called in a loop, resulting in the 'Maximum update depth exceeded' error.

App/src/hooks/useAutoFocusInput.ts

Line 57 in f5e6354

setIsInputInitialized(true);

Proposal:#47946 (comment)

[tgolen]

@Nodebrute OK, thank you for letting me know. Unless I'm missing something though, your issue is unrelated to what is causing the crash in the original description of this issue, right?

[Nodebrute]

@tgolen right, but I don’t think there are any open issues for this crash.

[dominictb]

@tgolen I will raise the PR in a few hours.

[tgolen]

@Nodebrute Thank you for clarifying! Please use our normal bug reporting process for the crash you found: https://github.com/Expensify/App/issues/new?assignees=&labels=Bug%2C+Daily&projects=&template=Standard.md

[dominictb]

@tgolen The PR is ready.

[puneetlath]

Demoting since the fix has been CP'd.

[tgolen]

Weekly Update

• The crash was fixed in this PR
• The regression is being handled in the original GH

Next Steps

• @tgolen Close this issue since the fix has been deployed to production

ETA

• Today, Aug 30