Expense - The app crashes when the administrator opens the details of a paid expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4888153
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

Create a new HT administrator account, create a new WS and invite a new HT employee account. For convenience, it is better to perform the steps in two tabs opened simultaneously.
Step:

1. Open https://staging.new.expensify.com/
2. Log in under the employee's account
3. Submit any manual expense in the WS room
4. Log in under the administrator account
5. Click on the expense payment button “Pay amount elsewhere”
6. Quickly click on the expense itself to open the details
7. Repeat steps 2-6 several times.

Expected Result:

The details of the paid expense should be opened by the adminstrator without crashing the application

Actual Result:

The app crashes when the administrator opens the details of a paid expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6580538_1724435181382.Recording__117__2_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-08-23 18:52:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when the administrator opens the details of a paid expense

What is the root cause of that problem?

The root cause is here we are falling back an empty string for report.policyID here which will fetch the whole policy tag collection

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 692 to 693 in 6488908

	policyTagList: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_TAGS}${report?.policyID ?? ''}`,

Then policyTagsList will have array elements which are not objects with tag prop so here we call hasEnabledTags

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 219 to 220 in 6488908

	const shouldShowTag = isPolicyExpenseChat && (transactionTag || OptionsListUtils.hasEnabledTags(policyTagLists));
	const shouldShowBillable = isPolicyExpenseChat && (!!transactionBillable || !(policy?.disabledFields?.defaultBillable ?? true) || !!updatedTransaction?.billable);

hasEnabledTags expects all array elements to be in that structure so calls Object.value on tag prop of the array which doesn't exist here

App/src/libs/OptionsListUtils.ts

Line 1317 in 6488908

const policyTagValueList = policyTagList.map(({tags}) => Object.values(tags)).flat();

So TypeError Cannot Conver null or undefined to object occurs and the app crashes

What changes do you think we should me in order to solve the problem?

Fallback should be something like -1

        key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_TAGS}${report?.policyID ?? '-1'}`,

We should similarly replace all other empty string fallbacks in other places too

What alternative solutions did you explore? (Optional)

[abzokhattab]

I'm curious why the fallback values in this file are set to empty strings.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 687 to 698 in 9f34483

	policy: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report?.policyID ?? ''}`,
	},
	policyCategories: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${report?.policyID ?? ''}`,
	},
	policyTagList: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_TAGS}${report?.policyID ?? ''}`,
	},
	parentReport: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID ?? ''}`,
	},

This change was introduced in this PR, so I'm tagging @kubabutkiewicz and @parasharrajat since they worked on it. Was this change intentional?

[parasharrajat]

@abzokhattab Probably a mistake. Default is -1 but it expects a string so mistakenly we left '' string instead.

[abzokhattab]

Thanks for clarifying, I thought there is a reason behind it, that's why I asked to avoid breaking intended functionalities.

[bernhardoj]

Dupe of #47542

[Christinadobrzyn]

Awesome, thanks @bernhardoj - closing as a dupe.