Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update trips empty state view #48060

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

daledah
Copy link
Contributor

@daledah daledah commented Aug 27, 2024

Details

Fixed Issues

$ #47937
PROPOSAL: #47937 (comment)

Tests

Precondition: There are no trip expenses.

  1. Open search page
  2. Navigate to trips
  3. Verify that: The screen displays the updated modal
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: There are no trip expenses.

  1. Open search page
  2. Navigate to trips
  3. Verify that: The screen displays the updated modal
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-09-09.at.16.34.14.mov
Android: mWeb Chrome
Screen.Recording.2024-09-10.at.16.27.41.mov
iOS: Native
Screen.Recording.2024-09-09.at.16.39.55.mov
iOS: mWeb Safari
Screen.Recording.2024-09-09.at.16.37.37.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-27.at.15.58.32.mov
MacOS: Desktop
Screen.Recording.2024-09-09.at.16.48.06.mov

@luacmartins luacmartins self-requested a review September 2, 2024 14:52
@luacmartins
Copy link
Contributor

@daledah what's the ETA to get this PR in review?

@daledah
Copy link
Contributor Author

daledah commented Sep 6, 2024

@luacmartins I can open ASAP if we agree to discuss #47937 (comment) in the PR phase.

@luacmartins
Copy link
Contributor

@daledah it seems like we just need to make sure the modal is not cut off and we need to update some styles to do that. Do you have any specific questions about that?

@daledah daledah marked this pull request as ready for review September 9, 2024 09:58
@daledah daledah requested review from a team as code owners September 9, 2024 09:58
@melvin-bot melvin-bot bot requested review from DylanDylann and removed request for a team September 9, 2024 09:58
Copy link

melvin-bot bot commented Sep 9, 2024

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dubielzyk-expensify
Copy link
Contributor

This card shouldn't be cut off. We should be showing the full card here and if it can't fit, then the whole view should be able to be scrolled
CleanShot 2024-09-09 at 20 22 57@2x

@shawnborton
Copy link
Contributor

Yup, totally agree with that. The inner modal itself should not be scrollable, just the view that wraps it.

@DylanDylann
Copy link
Contributor

Give a update in the issue: #47937 (comment)

@luacmartins
Copy link
Contributor

@daledah what's the latest here?

@daledah
Copy link
Contributor Author

daledah commented Sep 16, 2024

@DylanDylann @luacmartins Sorry for the delay. I updated to fix #48060 (comment). Please review again. Thanks!

@luacmartins
Copy link
Contributor

@daledah react compiler is failing

Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
❌ FAILED ❌ ❌ FAILED ❌
The QR code can't be generated, because the android build failed The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48060/NewExpensify.dmg https://48060.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@shawnborton
Copy link
Contributor

Looks like the empty state isn't filling up all of the available vertical space when the viewport height is taller:
CleanShot 2024-09-16 at 13 24 14@2x

See the difference here with other empty states:
CleanShot 2024-09-16 at 13 24 53@2x

src/languages/en.ts Outdated Show resolved Hide resolved
assets/animations/BankVault.lottie Outdated Show resolved Hide resolved
assets/animations/GenericEmptyState.lottie Outdated Show resolved Hide resolved
src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved
src/pages/Search/EmptySearchView.tsx Show resolved Hide resolved
src/pages/Search/EmptySearchView.tsx Outdated Show resolved Hide resolved
src/pages/Search/EmptySearchView.tsx Show resolved Hide resolved
@luacmartins
Copy link
Contributor

@daledah conflicts

src/pages/Search/EmptySearchView.tsx Show resolved Hide resolved
const hasAcceptedTravelTerms = travelSettings?.hasAcceptedTerms;
const hasPolicyAddress = !isEmptyObject(policy?.address);

const onBookATripPress = useCallback(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code comes from ManageTrips, right? If yes, let's create a Util function to DRY code

@DylanDylann
Copy link
Contributor

DylanDylann commented Sep 19, 2024

@daledah Also please check this problem

@luacmartins
Copy link
Contributor

@daledah what are the next steps here? Let's get this one to the finish line

@daledah
Copy link
Contributor Author

daledah commented Sep 23, 2024

@luacmartins I'm looking for a solution to #48060 (comment) without breaking the UI in smaller screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants