Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xero - App crashes when xero connected account disable 2FA and relog #48262

Closed
3 of 6 tasks
IuliiaHerets opened this issue Aug 29, 2024 · 5 comments · Fixed by #48283
Closed
3 of 6 tasks

Xero - App crashes when xero connected account disable 2FA and relog #48262

IuliiaHerets opened this issue Aug 29, 2024 · 5 comments · Fixed by #48283
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4901080&group_by=cases:section_id&group_id=309134&group_order=asc&group_by=cases:section_id&group_id=309134&group_order=asc
Email or phone of affected tester (no customers): applausetester+gm103061@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Preconditions:
User have 2FA enabled and Xero connected

Steps:

  1. Go to Security> Deactivate 2-FA
  2. Log out
  3. Enter same email address> Continue
  4. Enter the magic code

Expected Result:

App crashes when xero connected account disable 2FA and relog

Actual Result:

User logged without problem

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2908_2.txt

Bug6586392_1724927647934.Recording__3840.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 29, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 29, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets IuliiaHerets changed the title Web - Xero - App crashes when xero connected account disable 2FA and relog Xero - App crashes when xero connected account disable 2FA and relog Aug 29, 2024
@MonilBhavsar
Copy link
Contributor

Testing some reverts. The crash is probably because we're ending up in bad navigation state

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 29, 2024
@MonilBhavsar MonilBhavsar removed the DeployBlocker Indicates it should block deploying the API label Aug 29, 2024
@MonilBhavsar MonilBhavsar reopened this Aug 29, 2024
@MonilBhavsar
Copy link
Contributor

Tested on staging and it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
3 participants