[HOLD for payment 2024-10-08] Clean up Reanimated warnings

[roryabraham]

Problem

Somewhere between react-native-reanimated 3.8 and 3.13 a new dev warning was added to make worklet closures more strict and prevent common developer errors. These are just warnings and not errors for now, but there are many of them across the app.

This is distracting for developers and may be a sign that we are mis-using the library, which may in turn lead to other unintended consequences.

Solution

For now, let's suppress the warnings, since we aren't aware of any real problems being caused by this. Then let's (with lower priority) go through and clean them up and eventually un-suppress the warning to make sure we're using Reanimated correctly.

cc @WoLewicki

[BartoszGrajdek]

Hi! I’m Bartosz from SWM and I’m going to work on this issue 😄

[BartoszGrajdek]

I made some progress on this issue last week, but was delayed due to a higher-priority issue and a brief sick leave. I'm back now and will be making this my primary focus 👀

[BartoszGrajdek]

It got delayed longer than anticipated due to some other tasks at hand, but I believe there are no other warnings, than the ones I've noticed. I've tested it on all platforms and found 3 places where this warning was thrown:

1. Any screen using composer (Solved by Composer warn #48329)
2. Empty chat (Stopped happening on main, not sure which exact PR fixed this, but it doesn't happen anymore)
3. IOU Request Screen (PR with a fix is available here)

[hoangzinh]

PR was deployed to Prod yesterday. @roryabraham can you help to

• Assign me to this issue
• Add a bug/feature label so a BZ member will be assigned to this issue

to do payment later. Thank you.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[stephanieelliott]

Queuing this for payment after the regression period!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)
• Contributor: @BartoszGrajdek is from an agency-contributor and not due payment

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @BartoszGrajdek no payment due (external)
• Contributor+: @hoangzinh paid $250 via Upwork -- offer extended, please accept: https://www.upwork.com/nx/wm/offer/104330959

Upwork job is here: https://www.upwork.com/jobs/~021843802551890560225

[hoangzinh]

Accepted. Thanks @stephanieelliott

[mallenexpensify]

I paid @hoangzinh via Upwork because I needed to test the 'end contract' bug we're experiencing and grab a vid of it. Will let @stephanieelliott close this (I don't think it needs a regression test but def not certain)

[stephanieelliott]

Thanks @mallenexpensify! Yep this one is good to close.