Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - More features - Word is too close to the page border #48565

Closed
1 of 6 tasks
IuliiaHerets opened this issue Sep 4, 2024 · 13 comments
Closed
1 of 6 tasks

iOS - More features - Word is too close to the page border #48565

IuliiaHerets opened this issue Sep 4, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Device used is iPhone 15 Pro Max.
  • Device font size is third smallest font.
  1. Launch New Expensify app.
  2. Go to workspace settings > More features.

Expected Result:

"Each" in More features introduction sentence will not be too close to the page border.

Actual Result:

"Each" in More features introduction sentence is too close to the page border.

This issue is also reproducible on iPhone 14 with the second smallest font size (screenshot attached).

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6592730_1725445557531!15_Pro_Max_font_size
Bug6592730_1725445557540!iPhone_15_Pro_Max_bug
Bug6592730_1725445557548!iPhone14__bug

Bug6592730_1725445557532.ScreenRecording_09-04-2024_18-06-31_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @neil-marcellini
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 4, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 4, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@shubham1206agra
Copy link
Contributor

Offending PR #48389

@shubham1206agra
Copy link
Contributor

@Krishna2323
Copy link
Contributor

Krishna2323 commented Sep 4, 2024

thanks @shubham1206agra, I will take a look in few minutes.

@rayane-djouah
Copy link
Contributor

Let’s handle this in a follow-up PR. I don’t think it’s a blocker, as the issue is minor styling and only occurs on iOS native with specific font size settings.

@Krishna2323
Copy link
Contributor

@rayane-djouah, raising PR in few minutes.

@neil-marcellini
Copy link
Contributor

I agree this is not a blocker since it's a very small regression.

@neil-marcellini neil-marcellini removed the DeployBlockerCash This issue or pull request should block deployment label Sep 4, 2024
@RachCHopkins
Copy link
Contributor

@neil-marcellini automation is broken - does anyone here need to be paid, or can this be closed?

@RachCHopkins
Copy link
Contributor

Bump @neil-marcellini - is this closeable?

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 9, 2024
Copy link

melvin-bot bot commented Oct 9, 2024

This issue has not been updated in over 15 days. @neil-marcellini, @RachCHopkins eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 9, 2024
@neil-marcellini
Copy link
Contributor

Yeah the automation failed, but the PR fixing this is surely on production by now. No payment is needed because it was a follow up from the original PR that caused the regression #48389. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants