-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - More features - Word is too close to the page border #48565
Comments
Triggered auto assignment to @neil-marcellini ( |
Triggered auto assignment to @RachCHopkins ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Offending PR #48389 |
thanks @shubham1206agra, I will take a look in few minutes. |
Let’s handle this in a follow-up PR. I don’t think it’s a blocker, as the issue is minor styling and only occurs on iOS native with specific font size settings. |
@rayane-djouah, raising PR in few minutes. |
I agree this is not a blocker since it's a very small regression. |
@neil-marcellini automation is broken - does anyone here need to be paid, or can this be closed? |
Bump @neil-marcellini - is this closeable? |
This issue has not been updated in over 15 days. @neil-marcellini, @RachCHopkins eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Yeah the automation failed, but the PR fixing this is surely on production by now. No payment is needed because it was a follow up from the original PR that caused the regression #48389. Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
"Each" in More features introduction sentence will not be too close to the page border.
Actual Result:
"Each" in More features introduction sentence is too close to the page border.
This issue is also reproducible on iPhone 14 with the second smallest font size (screenshot attached).
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6592730_1725445557532.ScreenRecording_09-04-2024_18-06-31_1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @neil-marcelliniThe text was updated successfully, but these errors were encountered: