[HOLD for payment 2024-09-18] [$250] Web - Scan-"Description" and "Category" fields are disabled after dismissing "Allow location" modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.31-7
Reproducible in staging?: Y
**Reproducible in production?:**N
Issue was found when executing this PR: #48620
Email or phone of affected tester (no customers): applausetester+shsb22ertt@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Prerequisite
Make sure the location permission is denied on the browser settings

1. Log in to the new dot app
2. Create a new workspace
3. Go to the workspace chat and click on "+" > Submit expense
4. Go to the scan tab > Choose file
5. Upload a receipt to scan and click on submit
6. After the "Allow location" modal opens up click somewhere else outside the modal
7. After the modal is dismissed observe the "Description" and "Category" fields

Expected Result:

The "Description" and "Category" fields are clickable and can be edited

Actual Result:

The "Description" and "Category" fields are disabled and can not be clicked

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598078_1725921708521.2024-09-09_23_24_55.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833442936289826320
• Upwork Job ID: 1833442936289826320
• Last Price Increase: 2024-09-10
• Automatic offers:
• akinwale | Reviewer | 103895037
• Krishna2323 | Contributor | 103896856
• ikevin127 | Contributor | 103896860

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[mkzie2]

Edited by proposal-police: This proposal was edited at 2023-10-03T12:00:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Description" and "Category" fields are disabled and can not be clicked

What is the root cause of that problem?

When we press Confirm, we first set didConfirm then call onConfirm:

App/src/components/MoneyRequestConfirmationList.tsx

Lines 779 to 780 in 1725041

	setDidConfirm(true);
	onConfirm?.(selectedParticipants);

didConfirm disables the MenuItems for Category and Description:

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 437 in 1725041

disabled={didConfirm}

At this moment, the location permission modal appears and we close the modal without explicitly deny or grant the permission, at this step, we simply close the modal but didConfirm state set above is still true:

App/src/components/LocationPermissionModal/index.tsx

Lines 80 to 83 in 1725041

	const closeModal = () => {
	setShowModal(false);
	resetPermissionFlow();
	};

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 619 in 1725041

resetPermissionFlow={() => setStartLocationPermissionFlow(false)}

So the root cause is that when we close the permision modal, we simply close it without reseting the states inside MoneyRequestConfirmationList states including didConfirm which disabled the IOU's menu items previously.

What changes do you think we should make in order to solve the problem?

Introduce an effect inside MoneyRequestConfirmationList which reset didConfirm to false when we startLocationPermissionFlow changes from true to false. Of course we need to pass startLocationPermissionFlow to MoneyRequestConfirmationList as well.

useEffect(() => {
   setDidConfirm(!startLocationPermissionFlow);
), [startLocationPermissionFlow]);

Optionally, we can reset other states that we already changed in onConfirm before like formError or didConfirmSplit:

App/src/components/MoneyRequestConfirmationList.tsx

Line 767 in 1725041

setDidConfirmSplit(true);

App/src/components/MoneyRequestConfirmationList.tsx

Line 762 in 1725041

setFormError('common.error.invalidAmount');

[flodnv]

Optionally, we can reset other states that we already changed in onConfirm before like formError or didConfirmSplit:

Let's do that yes

Can you identify the PR which caused this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833442936289826320

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @mkzie2 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[mkzie2]

@flodnv The one mentioned in OP: #48620

[mkzie2]

Am I assigned to this job?

[Krishna2323]

@flodnv, this is also a regression from the same PR, can I fix both of then in a single PR?

EDIT: I have an emergency and need to go out for 1-2 hours. I'll complete the checklist right after I get back to my workplace.

[flodnv]

Sure, thanks @Krishna2323

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[flodnv]

Huh? @greg-schroeder I think we need to undo these offers as they are to resolve deploy blockers which were just introduced.

[Julesssss]

Thanks @Krishna2323, please feel free to request a review from me.

[luacmartins]

This is fixed on staging. This is a regression so closing since no payment is due

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.31-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Web - Scan - 'Description' and 'Category' fields are disabled after dismissing 'Allow location' modal. #48923

If no regressions arise, payment will be issued on 2024-09-18. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@flodnv / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@flodnv / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@flodnv / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Krishna2323] Determine if we should create a regression test for this bug.
• [@Krishna2323] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: