Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep getting put into #focus mode across platforms #48917

Open
1 of 6 tasks
m-natarajan opened this issue Sep 10, 2024 · 18 comments
Open
1 of 6 tasks

keep getting put into #focus mode across platforms #48917

m-natarajan opened this issue Sep 10, 2024 · 18 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-20
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725929489084449

Action Performed:

  1. Select preference mode as "Most recent"
  2. Signed out of Desktop/Web
  3. Signed in

Expected Result:

User remains in Most recent mode

Actual Result:

User forced into #focus mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Recording.532.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mallenexpensify
Copy link
Contributor

This is also happening to @rushatgabhane who commented on the Slack thread

backend bug. it keeps sending the nvp as false

The setting to mute sounds is also reset. Both have happened to me many times

@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2024
Copy link

melvin-bot bot commented Sep 16, 2024

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Sep 18, 2024

@puneetlath Still overdue 6 days?! Let's take care of this!

@rushatgabhane
Copy link
Member

rushatgabhane commented Sep 18, 2024

internal issue. please assign hot pick / internal label

🎀 👀 🎀

Copy link

melvin-bot bot commented Sep 18, 2024

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Sep 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2024
@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels Sep 19, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2024
@mallenexpensify
Copy link
Contributor

Sorry for fussing with labels and assignment. I thought it might be helpful to try to get a different engineer assigned, but that shouldn't be necessary.

@puneetlath
Copy link
Contributor

@mallenexpensify I'm headed OOO for a bit and I have too many NewDot Quality issues assigned right now. I'm going to use the auto-assigner to get someone else.

@puneetlath puneetlath added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Sep 21, 2024
Copy link

melvin-bot bot commented Sep 21, 2024

Triggered auto assignment to @MonilBhavsar (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Sep 24, 2024

@mallenexpensify @MonilBhavsar this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@MonilBhavsar
Copy link
Contributor

I'll take a look today

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 25, 2024
@MonilBhavsar
Copy link
Contributor

Submitted PR for review

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 25, 2024

@MonilBhavsar @rushatgabhane will this also fix the similar bug where Mute all sounds from Expensify is also toggled at the same time as being forced into @Focus mode? ie. I have sounds muted and, when thrown into #focus mode, I also start getting notifications sounds.

@mallenexpensify
Copy link
Contributor

Commented here, let's fix the problem of a system setting (mute sound) not being saved when signing out/in. I'm guessing we want a stand-alone issue for that, right?

@MonilBhavsar
Copy link
Contributor

Yes, that's a completely different issue. Happy to be assigned to it though!

Copy link

melvin-bot bot commented Sep 30, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mallenexpensify
Copy link
Contributor

Thx @MonilBhavsar , created an issues, assigned you and Rushat for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

5 participants