[$250] Desktop - Onboarding - Modal doesn't open in desktop when navigating to incorrect URL

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48137
Issue reported by: Applause Internal Team

Action Performed:

Precondition: use gmail NEW account.

1. Desktop: Sign in as a new user > Join (Do not proceed onboarding flow)
2. Web: Sign in with the same user > refresh the page (to see onboarding modal)
3. Desktop: Select 'Manage my team's expenses'
4. Web: Change the URL to a random URL after .com, for example, /aaa (for desktop, enter the URL in the browser and press Enter).
5. Web: choose 'Open New Expensify' in popup

Expected Result:

Desktop: the onboarding modal work page is displayed.

Actual Result:

Desktop: page not found is displayed

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598525_1725962243501.desktop_onboarding_modal_fail.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836423410149372393
• Upwork Job ID: 1836423410149372393
• Last Price Increase: 2024-09-25

Issue Owner

Current Issue Owner: @ntdiary

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[tsa321]

@mollfpr This issue is related to the following code:

App/src/libs/actions/Report.ts

Lines 2687 to 2689 in 5224d91

	if (shouldSkipDeepLinkNavigation(route)) {
	return;
	}

In desktop the shouldSkipDeepLinkNavigation is:

App/src/libs/shouldSkipDeepLinkNavigation/index.desktop.ts

Lines 3 to 9 in 5224d91

	export default function shouldSkipDeepLinkNavigation(route: string) {
	// When deep-linking to desktop app with `transition` route we don't want to call navigate
	// on the route because it will display an infinite loading indicator.
	// See issue: https://github.com/Expensify/App/issues/33149
	if (route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) {
	return true;
	}

It is intentionally skipped due to this bug:

#33149

When testing, I use the new-expensify:/aaa instead of the usual address in the browser to open the desktop app.

I'm unsure if I should move the check after the onboarding logic due to this bug.
I am creating a follow-up PR if we decide to move the check after the onboarding logic.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

I think this is low priority, though I'll open it up to the community.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836423410149372393

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[mollfpr]

@JmillsExpensify Since this issue from @tsa321 PR: #48137, should we let them fix this?

[ntdiary]

It seems that PR #48955 has addressed this issue, so we can just close this here?

[melvin-bot]

@JmillsExpensify @ntdiary this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JmillsExpensify]

Nice, closing.