Expense - Expense preview is shown briefly after deleting expense and returning to main chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4955466
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM that has no unsettled expense.
3. Submit an expense.
4. Click on the expense preview.
5. Click on the report header.
6. Click Delete expense.
7. Delete the expense.

Expected Result:

The expense preview should not appear after deleting the expense and returning to the main chat (production behavior).

Actual Result:

The expense preview is shown briefly after deleting the expense and returning to the main chat.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601072_1726150029962.bandicam_2024-09-12_21-59-17-699.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[dangrous]

seems very minor (I'd argue shouldn't block deploy) but let me see if I can find a cause quickly!

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-12 15:45:18 UTC.```

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense preview is shown briefly after deleting expense and returning to main chat

What is the root cause of that problem?

We are using setTimeout here

App/src/pages/ReportDetailsPage.tsx

Lines 820 to 822 in 260c5cf

	setTimeout(() => {
	IOU.deleteMoneyRequest(iouTransactionID, requestParentReportAction, isSingleTransactionView);
	}, CONST.ANIMATED_TRANSITION);

What changes do you think we should make in order to solve the problem?

We should remove setTimeout

App/src/pages/ReportDetailsPage.tsx

Lines 820 to 822 in 260c5cf

	setTimeout(() => {
	IOU.deleteMoneyRequest(iouTransactionID, requestParentReportAction, isSingleTransactionView);
	}, CONST.ANIMATED_TRANSITION);

    ReportUtils.navigateBackAfterDeleteTransaction(navigateBackToAfterDelete.current, true);
                            if (!requestParentReportAction) {
                                return;
                            }

                                IOU.deleteMoneyRequest(iouTransactionID, requestParentReportAction, isSingleTransactionView);
                
                        }

What alternative solutions did you explore? (Optional)

[Nodebrute]

Regression from #48055

cc: @daledah @alitoshmatov @dangrous

[dangrous]

thanks @Nodebrute! I wish I had looked here instead of waiting 15 mins running git bisect to come up with the same source haha.

[luacmartins]

I'm gonna revert the offending PR.

[luacmartins]

This is fixed on staging. Closing.