[HOLD for payment 2024-10-25] [$250] Invoice - Invoice room is not archived after deleting the workspace offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User B has only one workspace.

1. Go to staging.new.expensify.com
2. {User A] Send an invoice to User B.
3. [User B] Pay the invoice using Pay as a business option.
4. [User B] Go offline.
5. [User B] Delete the workspace.
6. {User B] Go to invoice chat.

Expected Result:

The invoice chat should be archived after deleting the workspace offline.

Actual Result:

The invoice room is not archived after deleting the workspace offline.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601022_1726146959362.20240912_210831.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841806197088184582
• Upwork Job ID: 1841806197088184582
• Last Price Increase: 2024-10-10
• Automatic offers:
• dukenv0307 | Reviewer | 104360901

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[IuliiaHerets]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invoice room is not archived after deleting the workspace offline.

What is the root cause of that problem?

When deleting workspaces, we choose what report to be archived here:

App/src/libs/actions/Policy/Policy.ts

Lines 312 to 314 in 7748eff

	const reportsToArchive = Object.values(ReportConnection.getAllReports() ?? {}).filter(
	(report) => report?.policyID === policyID && (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),
	);

However, an invoice sent from user A will have policyID of A's WS, not of B's WS, so the condition report?.policyID === policyID is false, hence the chat room not archived.

What changes do you think we should make in order to solve the problem?

We should add logic to include invoice chat sent from others as well, like what we did here

Update this:

App/src/libs/actions/Policy/Policy.ts

Line 313 in 7748eff

(report) => report?.policyID === policyID && (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),

to:

(report) =>
            (report?.policyID === policyID || (report?.invoiceReceiver && 'policyID' in report?.invoiceReceiver && report?.invoiceReceiver.policyID == policyID)) &&
            (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),
    

What alternative solutions did you explore? (Optional)

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

reviewing today!

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@davidcardoza can you confirm if this is unexpected behavior?

[davidcardoza]

Do we archive workspace rooms after a workspace is delete? If yes, an invoice room should follow the same pattern.

[melvin-bot]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[davidcardoza]

Any update on this issue?

[melvin-bot]

@dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[dylanexpensify]

@davidcardoza sorry for delay, yes, we do archive rooms when a workspace is deleted, so agree we follow that logic here with invoice rooms.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841806197088184582

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Reassigning as I head to parental leave next week! Thanks Tom!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: archive invoice room when deleting workspace #50624

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment automatic offer (Reviewer)
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time!

[jasperhuangg]

Awaiting checklist cc @dukenv0307

[trjExpensify]

For Melv, agreed!

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

• Precondition:

1. User B has a WS
2. User A send an invoice to user B

• Steps:

1. User B pay using "Pay as a business" option
2. User B go offline
3. User B Delete the workspace.
4. User B Go to Invoice chat
5. Verify that: Invoice chat is archived

Do we 👍 or 👎

[dukenv0307]

@jasperhuangg I completed the checklist

[trjExpensify]

Payment summary as follows:

• $250 to @daledah for the fix (paid!)
• $250 to @dukenv0307 for the C+ review (paid!)

[trjExpensify]

@davidcardoza for the invoice project, are regression tests being handed over centrally to Applause to add to TestRail, and is one for deleting the workspace and archiving the invoice room included?

[davidcardoza]

Yes, test cases to cover invoices were added to TestRail - https://github.com/Expensify/Expensify/issues/410043

There is not a test for deleting the workspace and archiving the invoice room. I can add it a new regression test to to it though. Before I spin up a new GH to add the QA test, is what's missing this:

1. Deleting a workspace and archiving a room when there is an unpaid invoice in the room
2. Deleting a workspace and archiving a room when there is an paid invoice in the room

Anything else?

[trjExpensify]

I think that covers it!

[trjExpensify]

Cool, so everyone is paid here now. I'll close it out!

[melvin-bot]

@trjExpensify @jasperhuangg Be sure to fill out the Contact List!