[$250] [HOLD for payment 2024-09-23] Bank account - Bank account modal prompts user to verify account after being done validating

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): nathanmulugetatesting+1484@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com and sign up with a new unvalidated Gmail account
2. Create a workspace
3. Enable workflows
4. Click on connect to bank account
5. Update currency to usd if already not
6. Click on "Verify your account here" link and validate your account

Expected Result:

After validating account bank account setup continues

Actual Result:

After validating account bank account setup continues

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603195_1726295110542.bandicam_2024-09-14_09-18-53-000.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839023851099596990
• Upwork Job ID: 1839023851099596990
• Last Price Increase: 2024-09-25

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[ishpaul777]

offending PR #49130, cc @CyberAndrii @s77rt @francoisl @

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account modal prompts user to verify account after being done validating

What is the root cause of that problem?

Here we set user validated to true but then in this page we check for account?.Validated

App/src/libs/actions/User.ts

Lines 623 to 627 in 0c618ac

	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.USER,
	value: {
	validated: true,
	},

What changes do you think we should make in order to solve the problem?

We can change User to ACCOUNT

App/src/libs/actions/User.ts

Lines 623 to 627 in 0c618ac

	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.USER,
	value: {
	validated: true,
	},

What alternative solutions did you explore? (Optional)

Or we can keep the user and also add a new entry here
validated: true,

[CyberAndrii]

Damn, I accidentally reverted that line while I was reverting other changes 🤦

But I agree we should include both of them to be safe

{
    onyxMethod: Onyx.METHOD.MERGE, 
    key: ONYXKEYS.ACCOUNT, 
    value: {
        isLoading: false,
        validated: true, 
    },
},
{
    onyxMethod: Onyx.METHOD.MERGE, 
    key: ONYXKEYS.USER, 
    value: {
        validated: true, 
    },
},

[s77rt]

@CyberAndrii This happens only optimistically right? IOW if we refresh the page the error would disappear? If so, I agree with the suggested solution, please raise a PR asap

[CyberAndrii]

PR is ready.

@s77rt after reloading (without the changes from the PR) the error don't disappear. However, I don’t think we need a BE fix here

[s77rt]

@CyberAndrii If you logout and login, do you still see the error?

This bug could be related to the BE if that flow is still using user.validated internally. If that's the case we should revert the PR (to unblock the deploy), make the necessary changed in BE and then re-submit the PR (basically same as the plan)

[CyberAndrii]

No error, BE sets the value correctly

[s77rt]

Unfortunately I'm unable to reproduce the bug (asked in Slack). @ishpaul777 If you can reproduce both the initial bug and this new bug, do you want to take that issue over and review/test the follow up PR?

[ishpaul777]

sure i can try reproducing... 👀

[ishpaul777]

let discusss on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1726358698700859

[grgia]

We discussed and decided to move forward with the fix proposed in #49221

[ishpaul777]

please assign me so this is on my K2 🙏

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Optimistically set account.validated on validation #49221

If no regressions arise, payment will be issued on 2024-09-23. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Payment Summary:

• Reviewer: @ishpaul777 $250

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ishpaul777]

No regression test and checklist requires, since this was caught in normal deploy QA process and we already know offending PR #49221

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839023851099596990

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[garrettmknight]

@ishpaul777 offer out to you

[ishpaul777]

Thank You.
Offer Accepted !

[garrettmknight]

Paid, closing!