Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Add Helper Text To NetSuite Custom segments/records and Custom lists fields #49409

Open
yuwenmemon opened this issue Sep 18, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Sep 18, 2024

Problem

Right now, with NetSuite, if you're importing Custom Segments / Lists, we kind of hide that fact visually in the config. For example below this is what we see even though Custom Segments and Lists are present in the connection config:

Screenshot 2024-09-17 at 11 44 47 PM (1)

Screenshot 2024-09-17 at 11 43 52 PM

Solution

Add a helper "value" underneath Custom segments/records and Custom lists on the "Import" page for the NetSuite connection, similar to what we have for Departments, Classes, Locations and other fields.

  • If all Custom segments/records or Custom lists are being imported as tags it should read:
    • Imported as tags
  • If all Custom segments/records or Custom lists are being imported as report fields it should read:
    • Imported as report fields
  • If all Custom segments/records or Custom lists are being imported as a mix of report fields and tags it should read:
    • Imported as tags and report fields

cc @zsgreenwald @jamesdeanexpensify @mananjadhav @shubham1206agra

Slack thread: https://expensify.slack.com/archives/C06ML6X0W9L/p1726642272240069

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836470482098534466
  • Upwork Job ID: 1836470482098534466
  • Last Price Increase: 2024-09-18
  • Automatic offers:
    • akinwale | Reviewer | 104025552
@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2024
@yuwenmemon yuwenmemon self-assigned this Sep 18, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mananjadhav
Copy link
Collaborator

@yuwenmemon do I want me to work on this ?

@yuwenmemon yuwenmemon changed the title [NetSuite] Add Helper Text To NetSuite Custom segments/records and Custom lists fields Add Helper Text To NetSuite Custom segments/records and Custom lists fields Sep 18, 2024
@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 18, 2024
@melvin-bot melvin-bot bot changed the title Add Helper Text To NetSuite Custom segments/records and Custom lists fields [$250] Add Helper Text To NetSuite Custom segments/records and Custom lists fields Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021836470482098534466

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

@yuwenmemon
Copy link
Contributor Author

@mananjadhav you are free to pick it up if you want! Just figured I'd highlight it for you since you worked on this originally 🙂

@shubham1206agra
Copy link
Contributor

I can review here if you want

@mananjadhav
Copy link
Collaborator

mananjadhav commented Sep 18, 2024

Will work on it.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@joekaufmanexpensify
Copy link
Contributor

@mananjadhav is there an ETA for PR here?

@mananjadhav
Copy link
Collaborator

Yes I’ll publish by tomorrow IST

@joekaufmanexpensify
Copy link
Contributor

Got it, sounds good!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Sep 22, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 22, 2024
@joekaufmanexpensify
Copy link
Contributor

PR in review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants