Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search v2.3] Make the popover menu modal closable by swiping down #49441

Closed
lakchote opened this issue Sep 19, 2024 · 3 comments
Closed

[Search v2.3] Make the popover menu modal closable by swiping down #49441

lakchote opened this issue Sep 19, 2024 · 3 comments
Assignees
@lakchote @DylanDylann
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lakchote
Copy link
Contributor

lakchote commented Sep 19, 2024 •
edited by melvin-bot bot
Loading

See #48566 (comment)

Issue OwnerCurrent Issue Owner: @DylanDylann
@lakchote lakchote added External Added to denote the issue can be worked on by a contributor Engineering Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 19, 2024
@lakchote lakchote self-assigned this Sep 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@nkdengineer
Copy link
Contributor

@lakchote What is the swiping-down action? It would be helpful to have an example video about this bug.

@lakchote
Copy link
Contributor Author

@lakchote What is the swiping-down action? It would be helpful to have an example video about this bug.

I've retested it, and this fixed it.
https://github.com/user-attachments/assets/a9f89dde-6e46-4e6e-b3f7-a3b2d28717d7

Previously, we weren't able to close the modal down by swiping downwars from the header.

Discussed it with @jjcoffee and we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakchote lakchote

@DylanDylann DylanDylann

Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
[#whatsnext] #wave-control
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lakchote @DylanDylann @nkdengineer