[$250] Mentioning approver in report overwrites their write capabilities and stops them from being able to comment on the report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.38-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726768176167369

Action Performed:

1. Create workspace
2. Enable workflows
3. Invite submitter and approver
4. Enable approval - set approver
5. As submitter, create expense in workspace chat
6. As submitter, @ mention approver in expense/report

Expected Result:

Approver can still chat in report

Actual Result:

Approver’s permissions are reset to ‘read’ and they can’t comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021837112575767072107
• Upwork Job ID: 1837112575767072107
• Last Price Increase: 2024-09-20

Issue Owner

Current Issue Owner: @rlinoz

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021837112575767072107

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[garrettmknight]

Note that this might not be External but I'm starting it there to get a move on.

[melvin-bot]

@JmillsExpensify, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rlinoz]

OPening a PR soon to fix this.

[rlinoz]

PR is up!

[DylanDylann]

@rlinoz Do we require C+ on this issue?

[trjExpensify]

@rlinoz thanks for picking this up! ❤️

[rlinoz]

@DylanDylann no, it is internal only

[trjExpensify]

Auth PR is on prod, so this can be closed right?

[rlinoz]

Yes!