Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] User has two Concierge Chats #49507

Closed
1 of 6 tasks
thienlnam opened this issue Sep 19, 2024 · 35 comments
Closed
1 of 6 tasks

[$250] User has two Concierge Chats #49507

thienlnam opened this issue Sep 19, 2024 · 35 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Sep 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.38-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @anmurali
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1726787640487449

Action Performed:

  1. Create a new account
  2. Go to Classic by 'Switching to Expensify Classic' in settings
  3. Open an incognito tab and log in again
  4. Click Support > Concierge
  5. Transition to NewDot
  6. Land in this optimistic concierge and notice that there are two concierge chats

Expected Result:

There should not be an optimistic concierge chat created

Actual Result:

Sometimes, there are two concierge chats that persist.
The actual one, and then the optimistic one
Other times, the optimistic one disappears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

[Internal]
Here are the two FS sessions
https://fsty.io/v/yjbdRZ5H
https://fsty.io/v/q9bsx2kv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836917539166842207
  • Upwork Job ID: 1836917539166842207
  • Last Price Increase: 2024-10-10
Issue OwnerCurrent Issue Owner: @suneox
@thienlnam thienlnam added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021836917539166842207

@melvin-bot melvin-bot bot changed the title User has two Concierge Chats [$250] User has two Concierge Chats Sep 19, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@thienlnam thienlnam self-assigned this Sep 19, 2024
@trjExpensify
Copy link
Contributor

I simulated the customer steps here by signing-up on Classic and turning my network to crappy 3G:

  1. Sign-up on Classic (use a private domain so you don't get redirected)
  2. Click Support > Concierge
  3. Transition to NewDot
  4. Landed in an optimistic Concierge chat
  5. Eventually that chat did disappear though, but for the customer it didn't.
2024-09-20_01-06-01.mp4

Copy link

melvin-bot bot commented Sep 23, 2024

@suneox, @trjExpensify, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@suneox
Copy link
Contributor

suneox commented Sep 24, 2024

We’re still looking for a proposal. I can simulate the issue with the following steps:

  1. Sign out from the new dot.
  2. Click Support > Concierge from the old dot.
  3. Simulate a slow network connection.
Screen.Recording.2024-09-24.at.11.04.10.mp4

@melvin-bot melvin-bot bot removed the Overdue label Sep 24, 2024
@trjExpensify
Copy link
Contributor

@thienlnam is this actually going to be external?

@huult
Copy link
Contributor

huult commented Sep 25, 2024

I can reproduce this issue and I am investigating it. Please give me more time; I will post a proposal soon.
cc: @trjExpensify

@trjExpensify
Copy link
Contributor

Sure thing!

Copy link

melvin-bot bot commented Sep 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@trjExpensify
Copy link
Contributor

@huult can you provide an update?

@huult
Copy link
Contributor

huult commented Sep 26, 2024

@trjExpensify I'm still investigating and find RCA.
Summarize what I know: After logging in, the Concierge report is added to the list of reports, but that report does not have a chatType. I don’t know where the report is handled by code, so I am still investigating to resolve this issue.

@muttmuure
Copy link
Contributor

This is a duplicate of a bug we're already working on #48746

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
@trjExpensify
Copy link
Contributor

Hm, don't close this until you confirm that. We can put it on hold and retest this flow where we transition with the ShortLivedAuthToken for support.

@trjExpensify trjExpensify reopened this Sep 26, 2024
@huult
Copy link
Contributor

huult commented Sep 27, 2024

@trjExpensify Can I continue investigating this issue, or is this ticket on hold #48746?

@ugogiordano
Copy link

Hello @trjExpensify, could you please review my proposal on issue 44465? It should also address this issue. Thank you!

Copy link

melvin-bot bot commented Sep 28, 2024

📣 @ugogiordano! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Sep 28, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@ugogiordano
Copy link

Contributor details
Your Expensify account email: ugo.giordano1987@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0113b790fc6c7a1ad9

Copy link

melvin-bot bot commented Sep 28, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@trjExpensify
Copy link
Contributor

I'll let @getusha do that. (link to the proposal comment for ease).

@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2024
@trjExpensify
Copy link
Contributor

@getusha bump on the proposal for the other issue?

@getusha
Copy link
Contributor

getusha commented Oct 3, 2024

@trjExpensify reviewing! i am also trying to reproduce it on dev

Copy link

melvin-bot bot commented Oct 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Oct 3, 2024

@suneox @trjExpensify @thienlnam this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@trjExpensify
Copy link
Contributor

@trjExpensify reviewing! i am also trying to reproduce it on dev

Great, keep me posted!

@suneox
Copy link
Contributor

suneox commented Oct 8, 2024

@MelvinBot Not overdue, we're still waiting for confirmation on whether the proposal from #44465 can resolve the issue

@melvin-bot melvin-bot bot removed the Overdue label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@wildan-m
Copy link
Contributor

Any idea on how to generate that link with authentication in dev?

I also have solutions here: #44465 (comment)

But it seems the result can be seen if we deploy to staging.

@getusha this is another way to reproduce the duplicate concierge chat issue, but I'm not sure how to reproduce it in dev.

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2024
@huult
Copy link
Contributor

huult commented Oct 16, 2024

@wildan-m Check my comment

@trjExpensify
Copy link
Contributor

^^ @wildan-m if that doesn't do it, bring it out to #expensify-open-source.

@wildan-m
Copy link
Contributor

wildan-m commented Oct 17, 2024

@huult thanks! that reproduction steps works.

@trjExpensify @getusha @suneox I can confirm this issue shares the same root cause with #44465.

Here is the video that implement one of my solution (Alternative 3) #44465 (comment)

Kapture.2024-10-17.at.11.28.00.mp4

@flaviadefaria
Copy link
Contributor

How are we doing here, if it's the same root cause then should we close this in favor of the proposal in #44465?

@trjExpensify
Copy link
Contributor

Yes, no point having two open. @wildan-m @getusha let's also just make sure both cases are covered in the testing steps of the PR for this.

@trjExpensify
Copy link
Contributor

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

9 participants